Vendor latest release-v133-desktop (22bad8d5f740be76dac3f7e6521521d52ca17157) to 133 for city-based weather
Categories
(Application Services :: General, task, P1)
Tracking
(firefox133 fixed)
Tracking | Status | |
---|---|---|
firefox133 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
Details
(Whiteboard: [sng-cityweather])
Attachments
(1 file)
97.71 KB,
patch
|
dmeehan
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Vendor the latest release-v133-desktop (22bad8d5f740be76dac3f7e6521521d52ca17157 to 133 for desktop city-based weather suggestions.
Updated•1 month ago
|
Assignee | ||
Comment 1•1 month ago
|
||
Approval Request Comment
[Feature/Bug causing the regression]: City-based weather suggestions on desktop (new feature, not a regression)
[User impact if declined]: This has important fixes to weather suggestions on desktop, which we want for 133
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: Low risk
[Why is the change risky/not risky?]: The only substantive new commits in this vendoring as compared to what's already been vendored in 133 are two patches related to weather suggestions. (There are more commits than two, but one is a merge commit and three others are part of the same PR that I meant to squash before originally merging.) Weather suggestions are desktop-only and are preffed off by default.
[String changes made/needed]: None
Assignee | ||
Comment 2•1 month ago
|
||
Try push with likely a lot of known orange since I chose many tests:
https://treeherder.mozilla.org/jobs?repo=try&revision=5aa910bd5f38f691da737e6c3c2c3efd36ec1f83
Assignee | ||
Updated•1 month ago
|
Comment 4•1 month ago
|
||
Comment on attachment 9435757 [details] [diff] [review]
a-s-vendor-release-v133-desktop-22bad8d5f740be76dac3f7e6521521d52ca17157
Approved for 133.0b6
Updated•1 month ago
|
Description
•