1929525 - [Menu redesign] There are no ellipses once the email address/display name reached the max width of the label

Status: VERIFIED FIXED

(Fenix :: WebExtensions, defect, P3)

Description

[Vasilica Tamas QA [:vtamas]]

Attachment: LongEmailAddress.JPEG

Preconditions

Enable Menu Redesign feature from Secret Settings.

Steps to reproduce

1. Tap on 3 dots menu.
2. Tap on Sign in and login using a Firefox Account with a long email address or display name.
3. Open again the Main menu and check the Account section.

Expected behavior

The Firefox Account email address/display name is interrupted by ellipses once the max width is reached.

Actual behavior

There are no ellipses once the Firefox Account email address/display name reached the max width of the label.

Device information

• Firefox version: Firefox Nightly 134 (2024-11-06)
• Android device model: Samsung Galaxy S24 Ultra (Android 14), Xiaomi 12T (Android 12)

Comment 1

[Zac McKenney [:zmckenney]]

Attachment: Bug 1929525 - Add ellipses to email overflow in menu redesign

Comment 2

[Zac McKenney [:zmckenney]]

Attachment: fixed-email-with-ellipses.png

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c954e4a5e67
Add ellipses to email overflow in menu redesign r=android-reviewers,giorga

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/5c954e4a5e67

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:zmckenney, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Vasilica Tamas QA [:vtamas]]

Attachment: 3a68343e-f823-4554-8009-bdb4b68173ef.JPEG

This issue is verified as fixed on Firefox Nightly 135 (2024-11-29) under Samsung S24 Ultra (Android 14), Poco X6 Pro (Android 14) and Xiaomi 12T (Android 12). Confirming that the ellipses are successfully displayed at the end of the email address/display name.