1929531 - Change the ESLint mozilla/reject-addtask-only rule to highlight only the .only() section

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Mark Banner (:standard8)]

Currently, when we add .only() on an add_task(), ESLint will report the failure against the whole block of:

add_task(async function test() {
  ...
}.only();

Generally, this is fine, but for code highlighters this means they flag the whole add_task definition with red line indicators, which then get in the way of development - and I've heard in the past, that developers don't use it because of this issue.

I think we should change the rule to highlight only the .only() part. This should make more sense anyway, as the suggestion to remove it will remove just that part.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1929531 - Change the ESLint mozilla/reject-addtask-only rule to highlight only the .only() section. r?#frontend-codestyle-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a399a9bd5f78
Change the ESLint mozilla/reject-addtask-only rule to highlight only the .only() section. r=frontend-codestyle-reviewers,mossop

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a399a9bd5f78