Closed
Bug 1929531
Opened 1 month ago
Closed 26 days ago
Change the ESLint mozilla/reject-addtask-only rule to highlight only the .only() section
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox134 fixed)
RESOLVED
FIXED
134 Branch
Tracking | Status | |
---|---|---|
firefox134 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
Currently, when we add .only()
on an add_task()
, ESLint will report the failure against the whole block of:
add_task(async function test() {
...
}.only();
Generally, this is fine, but for code highlighters this means they flag the whole add_task definition with red line indicators, which then get in the way of development - and I've heard in the past, that developers don't use it because of this issue.
I think we should change the rule to highlight only the .only()
part. This should make more sense anyway, as the suggestion to remove it will remove just that part.
Assignee | ||
Comment 1•1 month ago
|
||
Updated•1 month ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a399a9bd5f78
Change the ESLint mozilla/reject-addtask-only rule to highlight only the .only() section. r=frontend-codestyle-reviewers,mossop
Comment 3•26 days ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 26 days ago
status-firefox134:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•