1929567 - [Tab Strip] Consider adding the PB mask icon on Tabs counter in private mode

Status: VERIFIED FIXED

(Firefox for Android :: Tabs, defect, P2)

Description

[Delia Pop (Android QA)]

Attachment: Tab_Strip_PB_Mask_Icon.jpg

Steps to reproduce

1. On a tablet device go to private browsing mode.
2. Observe the tabs counter icon.
3. Open a tab and observe the tabs counter icon.

Expected behavior

The Tabs counter should be displayed with a PB mask icon in the upper right corner.

Actual behavior

The PB mask icon is missing from the Tab counter.

Device information

• Firefox version: Nightly 134.0a1 from 11/06
• Android device model/Android OS version: Samsung Tab S8 Ultra 5G (Android 14)

Any additional information?

The Figma design for Tab Strip does not include the PB mask icon on Tabs counter, however the Figma for the Toolbar Redesign shows that the Tab counter should display the PM mask icon.

Note that on phone devices the PB mask icon remains displayed, while on tablet devices the PB mask icon was removed from the Tabs counter after 1923855 . Since both features can be enabled at the same time on tablet devices, the design should be consistent.

Comment 1

[BugBot [:suhaib / :marco]]

:rsainani, since you are the author of the regressor, bug 1923855, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Rahul Sainani [:rsainani]]

Hi Delia, this was intended as specced in figma. I'll engage in the slack thread to get UX involved.

Comment 3

[Rahul Sainani [:rsainani]]

Attachment: Bug 1929567 - Show privacy badge on tabcounter in private mode

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8501c55e4cd7
Show privacy badge on tabcounter in private mode r=android-reviewers,007

Comment 5

[Goloman Adrian[:agoloman]]

https://hg.mozilla.org/mozilla-central/rev/8501c55e4cd7

Comment 6

[Delia Pop (Android QA)]

Attachment: Private_Badge.jpg

Verified as fixed in the latest Nightly 134.0a1 from 11/12. The badge icon is now displayed in private mode, when tab strip is enabled and across all devices.
Note that on Huawei MediaPad M2 (Android 5.1.1), the badge icon is still displayed as a black dot, as previously reported in bug 1860071.
Tested with Samsung GalaxyZ Fold 4 (Android 14), Samsung Tab S8 Ultra 5G (Android 14), Lenovo Yoga Tab 11 (Android 12), Samsung Galaxy S22 Ultra (Android 14) and Huawei MediaPad M2 (Android 5.1.1).