1929594 - Don't use opacity to style disabled menuitem

Status: RESOLVED FIXED

(DevTools :: Shared Components, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

See https://searchfox.org/mozilla-central/rev/aecb006bbb135d707ca4b8cea7572dd8abab6817/devtools/client/themes/tooltips.css#450-451,554,581-583

.tooltip-container[type="doorhanger"] {
  > .tooltip-panel {
...
  .menuitem > .command {
...
    &[disabled] {
      opacity: 0.5;
    }

We should rather used one of our variable to adapt the color of the text

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1929594 - [devtools] Use --theme-text-color-inactive for disabled menu items instead of tweaking the opacity. r=#devtools.

This makes the element nicely adapt to High Contrast Mode.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/042ce18dd1e9
[devtools] Use --theme-text-color-inactive for disabled menu items instead of tweaking the opacity. r=devtools-reviewers,ochameau.

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/042ce18dd1e9