192962 - Optimized builds do not include string.h

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[tenthumbs]

On Linux I get these warnings from an optimized build while building
mozilla (cvs trunk build).

 priometh.c:313: warning: implicit declaration of function `memcpy'
 prrng.c:45: warning: implicit declaration of function `memcpy'

They do not occur in a debug build.

Both files include only primpl.h.

I believe the problem actually occurs in nsprpub/pr/include/md/_unixos.h
where string.h is included only if DEBUG is defined.

Comment 1

[Wan-Teh Chang]

Thanks for the bug report.  I just checked in a fix
on the NSPR tip.

Note that I can't simply include <string.h> in
nsprpub/pr/include/md/_unixos.h because that header
is only used by Unix platforms but priometh.d and
prrng.c use memcpy on all platforms.