Open Bug 1929830 Opened 1 year ago Updated 5 months ago

Remove chrome_settings_overrides.search_provider.search_form schema definition

Categories

(Firefox :: Search, task, P3)

Product:
Firefox
Component:
Search
Type:
task

Tracking

()

People

(Reporter: robwu, Unassigned)

References

Details

(Whiteboard: [sng][search-tech-debt])

The search_form property was deprecated in bug 1903247. The only remaining part is in the extension schema at:
https://searchfox.org/mozilla-central/rev/113b09cdd5282b39db65b2f62abe843558b9471a/browser/components/extensions/schemas/chrome_settings_overrides.json#122-129

It is annotated with "Unsupported on Firefox at this time.". That does not serve any purpose; if the key is dropped altogether, we will fall back to UnrecognizedProperty, i.e. "An unexpected property was found in the WebExtension manifest." (source).

Let's just remove it. For context, this feature was added in bug 1496075 without documentation, and dropped in 1903247.

I audited public usage on AMO, and don't expect any breakage - all extensions that specify search_form also specify a meaningful value for search_url.

Severity: -- → N/A
Priority: -- → P3
Whiteboard: [snt-scrubbed][search-techdebt]
Whiteboard: [snt-scrubbed][search-techdebt] → [sng][search-tech-debt]
You need to log in before you can comment on or make changes to this bug.