1930105 - [menu redesign] The main menu has the same color as the homepage in private mode

Status: VERIFIED FIXED

(Fenix :: Toolbar, defect, P2)

Description

[Mira Lobontiu (Android QA)]

Attachment: privatehomepage.png

Steps to reproduce

1. From Secret Settings, enable the Menu redesign.
2. Go to private browsing and tap on the three-dot menu.
3. Fully expand the menu and observe.

Expected behavior

The menu is clearly differentiated from the private homepage.

Actual behavior

The menu is not clearly differentiated from the private homepage.

Device information

• Firefox version: Nightly 134.0a1 from 11/7
• Android devices: Samsung Galaxy Tab S9 Ultra (Android 14), Google Pixel 6 (Android 15)

Comment 1

[Chris Peterson [:cpeterson]]

This bug doesn't need to block enabling the new menu in Nightly, but we should fix it before our Beta experiment (meta bug 1898393).

Comment 2

[Chris Peterson [:cpeterson]]

Aarjav recommends changing the private browsing menu's opacity to alpha 100 in both light and dark modes.

Comment 3

[Aarjav [:aarjav]]

Also for tablet screen sizes.

This is possibly a temporary solution, can revisit this if there is negative user feedback.

We can't fix/change the colour right now because it is a last-minute change. That is a big undertaking for us. We need to find the colour, check A11y, change the colour in ADS, update designs, communicate with iOS, etc. I know we chose that colour after a lot of trial and error. Comparatively, this bug isn't a big concern at the moment.

Comment 4

[Sanchaai [:sanchaai]]

Attachment: Bug 1930105 - The main menu has the same color as the homepage in private mode. r=giorga

Differentiate the main menu from the homepage in private mode by increasing the alpha value of the menu's scrim/background layer.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c68fb79b0d03
The main menu has the same color as the homepage in private mode. r=giorga,android-reviewers

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c68fb79b0d03

Comment 7

[Mira Lobontiu (Android QA)]

Attachment: samsungPrivateMode.png

Verified on the latest Fenix Nightly 134.0a1 from 11/20, with Samsung Galaxy Tab S9 Ultra (Android 14), and Google Pixel 6 (Android 15), that there is now a difference between the main menu and the private homescreen.