1930125 - textPath causes text to be translated incorrectly if the referenced path has a translation applied

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Dani Pärnänen]

Attachment: text-on-path.svg

Steps to reproduce:

Using SVG, render <text> on a <path> that has a translation transformation using <textPath> that references that path element.

Actual results:

The translation is applied correctly on the <path> element, but it is applied apparently two times on the <text> element resulting in the text being rendered in the wrong coordinates.

Expected results:

The text should be rendered exactly on the path regardless of the path's transformations.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Translations' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mayank Bansal]

Bug 878346 - Make transform a mapped attribute for SVG. r=longsonr,firefox-style-system-reviewers,zrhoffman

The tricky bit is rotate() which in SVG means something different if
there's an origin (you translate-then-untranslate it).

But this seems to work off-hand, and fix the reminder of bug 1906261.

Differential Revision: https://phabricator.services.mozilla.com/D215788

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 878346

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1930125 - Make SVGGeometryElement::LocalTransform return CSS rather than device pixels. r=longsonr,#layout

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9436735 [details]
Bug 1930125 - Make SVGGeometryElement::LocalTransform return CSS rather than device pixels. r=longsonr,#layout

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: One liner regression fix
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0 (but attachment needs to be open on a new tab on a highdpi screen)
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively well scoped patch.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/306959be9a2a
Make SVGGeometryElement::LocalTransform return CSS rather than device pixels. r=longsonr

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for causing reftests failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/svg/text/textpath-transform-zoom.html == layout/reftests/svg/text/textpath-transform-zoom-ref.html | image comparison, max difference: 255, number of differing pixels: 2976

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee852da735ef
Make SVGGeometryElement::LocalTransform return CSS rather than device pixels. r=longsonr

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ee852da735ef

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9436735 [details]
Bug 1930125 - Make SVGGeometryElement::LocalTransform return CSS rather than device pixels. r=longsonr,#layout

Approved for 133.0b8

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2e575bfc98f0

Comment 12

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to reproduce the issue on an affected Firefox 133.0b7 build, using macOS 13.6.7 (2048 x 1280) and macOS 14.7 (1792 × 1120) by loading the .svg file from Comment 0 in a new tab.
Verified as fixed on Firefox 133.0b8 and on Firefox Nightly 134.0a1 (2024-11-13), using macOS 13.6.7, macOS 14.7, Windows 11 and Ubuntu 22.04. The text is correctly rendered along the path.
Please note that on Windows and Ubuntu I've verified this with the scaling factor set above 125%, as the maximum resolution on those devices is 1920 x 1080.