1930154 - [Menu Redesign] "Switch to desktop site" menu item is enabled for a PDF in Custom tab

Status: VERIFIED FIXED

(Fenix :: Toolbar, defect, P3)

Description

[Vasilica Tamas QA [:vtamas]]

Attachment: SwitchToDesktopSite.JPEG

Preconditions

• Fenix is set as default browser.
• Enable Menu Redesign feature from Secret Settings.
• Make sure Toolbar Redesign feature is enabled in Secret Settings

Steps to reproduce

1. Open an external app (i.e. Gmail, Instagram, Slack) and tap on a PDF link.
2. Tap on 3 dots menu and check the "Switch to desktop site" menu item.

Expected behavior

"Switch to desktop site" menu item is disabled for PDFs.

Actual behavior

"Switch to desktop site" menu item is enabled for PDFs.

Device information

• Firefox version: Firefox Nightly 134 (2024-11-07)
• Android device model: Samsung S24 Ultra
• Android OS version: Android 14

Any additional information?

• This issue is not reproducible when opening a PDF in the app.

Comment 1

[Iorga Gabriel]

Attachment: Bug 1930154 - [Menu Redesign] "Switch to desktop site" menu item should not be enabled for a PDF in Custom tab.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e5d5d27852b
[Menu Redesign] "Switch to desktop site" menu item should not be enabled for a PDF in Custom tab. r=android-reviewers,petru

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/0e5d5d27852b

Comment 4

[Vasilica Tamas QA [:vtamas]]

Attachment: SwitchDisabled.JPEG

This issue is verified as fixed on Firefox Nightly (2024-11-15) using Samsung S24 Ultra (Android 14) and Oppo Find X3 Neo (Android 11). Confirming that "Switch to desktop site" menu item is disabled for PDFs in Custom tabs.