1930190 - Dedicated search dropdown doesn't follow Alpenglow theme

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Petruta Horea [:phorea]]

Attachment: address bar VS dedicated search background in Alpenglow theme

Found in

• Nightly 134.0a1;

Affected versions

• Nightly 134.0a1;

Affected platforms

• Windows 11; Ubuntu 24; macOS 13

Preconditions

• Have browser.urlbar.scotchBonnet.enableOverride to TRUE

Steps to reproduce

1. Set Firefox theme to Alpenglow from about:addons -> Themes
2. Open dedicated search button
3. Verify that the dropdown follows Alpenglow theme

Expected result

• Dedicated search dropdown has the same background as the address bar panel

Actual result

• Dedicated search dropdown has dark background, please check the screenshot.

Regression range

• Not a regression.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1930190: Apply arrowpanel colors to search mode switcher popup

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c15988b300db
Apply arrowpanel colors to search mode switcher popup r=desktop-theme-reviewers,daleharvey,dao

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/c15988b300db

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9438990 [details]
Bug 1930190: Apply arrowpanel colors to search mode switcher popup

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: The theme user selected does not apply to the search engine switcher popup.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is only its style.
• String changes made/needed: none
• Is Android affected?: No

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f5157e474b70

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-11-08 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 135.0a1 and Firefox 134.0b4 on Windows 10, Ubuntu 22, macOS 14.
Dedicated Search dropdown follows Alpenglow Theme.