1930247 - [wpt-sync] Sync PR 49074 - [FedCM] Allow arbitrary data as parameters instead of string/string pairs

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49074 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49074
Details from upstream follow.

Christian Biesinger <[e-mail]> wrote:

[FedCM] Allow arbitrary data as parameters instead of string/string pairs

As mentioned in the updated spec:
https://w3c-fedid.github.io/FedCM/#dom-identityproviderrequestoptions-params
https://w3c-fedid.github.io/FedCM/#ref-for-dom-identityproviderrequestoptions-params%E2%91%A0

Bug: 374073124
Change-Id: If828c00da8f89c6ea2b3724db0d75ed2eea2591c
Reviewed-on: https://chromium-review.googlesource.com/5990590
WPT-Export-Revision: 8e822ff0a9d1f1dfc07afb7f5ad2305c421c4274

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3f8cf06040b2f84a76afbe20cf329eb5ed1f191

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

TIMEOUT: 2
NOTRUN : 1

Chrome

PASS : 1
TIMEOUT: 2

Safari

OK : 1
FAIL : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /fedcm/fedcm-authz/fedcm-params.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], TIMEOUT [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: TIMEOUT, Safari: OK)
  • If a getter in a custom parameter object throws an exception, it should get passed through: TIMEOUT (Chrome: PASS, Safari: FAIL)
  • Parameters should be sent to the server correctly: NOTRUN (Chrome: TIMEOUT, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /fedcm/fedcm-authz/fedcm-params.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], TIMEOUT [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: TIMEOUT, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1489ad1c7fcf
[wpt PR 49074] - [FedCM] Allow arbitrary data as parameters instead of string/string pairs, a=testonly
https://hg.mozilla.org/integration/autoland/rev/01dd946caf3a
[wpt PR 49074] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1489ad1c7fcf
https://hg.mozilla.org/mozilla-central/rev/01dd946caf3a