1930254 - Move smartblock embed placeholder replacing logic into a content script

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P1)

Description

[William Wen (:wwen)]

Currently, the message to open the protections panel can be spoofed by websites. Moving the logic to put placeholders into the content script would fix this. See https://phabricator.services.mozilla.com/D223419#inline-1266455 for details.

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 1930254 - Convert SmartBlock embed scripts to content scripts. r=twisniewski!,wwen!

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1930254 - Only allow trusted clicks on SmartBlock embed opt-in button. r=twisniewski!

Comment 3

[Emma Zühlcke [:emz]]

Attachment: Bug 1930254 - Do not expose shim messaging helper to the website for embed shims that don't need it. r=robwu!,twisniewski!

Comment 4

[Emma Zühlcke [:emz]]

Attachment: Bug 1930254 - Copy updated webcompat extension files to mobile. r=twisniewski!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79fb564d6b88
Convert SmartBlock embed scripts to content scripts. r=twisniewski,wwen,robwu
https://hg.mozilla.org/integration/autoland/rev/6f292dd01e4a
Do not expose shim messaging helper to the website for embed shims that don't need it. r=robwu,twisniewski,webcompat-reviewers
https://hg.mozilla.org/integration/autoland/rev/62b87fb5c82a
Copy updated webcompat extension files to mobile. r=twisniewski,webcompat-reviewers

Comment 6

[Phabricator Automation]

Comment on attachment 9443177 [details]
Bug 1930254 - Only allow trusted clicks on SmartBlock embed opt-in button. r=twisniewski!

Revision D231572 was moved to bug 1942844. Setting attachment 9443177 [details] to obsolete.

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/79fb564d6b88
https://hg.mozilla.org/mozilla-central/rev/6f292dd01e4a
https://hg.mozilla.org/mozilla-central/rev/62b87fb5c82a