1930281 - Remove JSContext usage from baseline compiler

Status: NEW

(Core :: JavaScript Engine: JIT, task, P1)

Description

[Iain Ireland [:iain]]

As a prerequisite for offthread baseline compilation, we have to remove all uses of JSContext from the parts of the baseline compiler that we intend to run offthread.

Comment 1

[Iain Ireland [:iain]]

Attachment: Bug 1930281: Use CompileRuntime in BaselineCodegen r=jandem

Comment 2

[Iain Ireland [:iain]]

Attachment: Bug 1930281: Remove unnecessary rooting from MaybeOptimizeBindGlobalName r=jandem

I originally wrote this patch thinking that it would let us call MaybeOptimizeBindGlobalName offthread. In retrospect that obviously doesn't work, since it involves accessing global properties, but removing the rooting still seems worth landing now that I've written the patch.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9dc5524dd997
Use CompileRuntime in BaselineCodegen r=jandem
https://hg.mozilla.org/integration/autoland/rev/75af582dff0a
Remove unnecessary rooting from MaybeOptimizeBindGlobalName r=jandem

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9dc5524dd997
https://hg.mozilla.org/mozilla-central/rev/75af582dff0a

Comment 5

[Iain Ireland [:iain]]

Attachment: Bug 1930281: Move IonCompileable checks out of constructor r=jandem

Comment 6

[Iain Ireland [:iain]]

Attachment: Bug 1930281: Don't pass JSContext to handler r=jandem

Comment 7

[Iain Ireland [:iain]]

Attachment: Bug 1930281: Refactor some error handling r=jandem

Comment 8

[Iain Ireland [:iain]]

Attachment: Bug 1930281: Store globals in baseline compiler r=jandem

Eventually I think this data should move to some sort of BaselineSnapshot struct, but for now I'm just putting it in the handler.

Comment 9

[Iain Ireland [:iain]]

Attachment: Bug 1930281: Generate DebugTrapHandler earlier r=jandem

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b1ed4ac7afa
Move IonCompileable checks out of constructor r=jandem
https://hg.mozilla.org/integration/autoland/rev/31ca9b2fa3a5
Don't pass JSContext to handler r=jandem
https://hg.mozilla.org/integration/autoland/rev/9c0e67cd9404
Refactor some error handling r=jandem
https://hg.mozilla.org/integration/autoland/rev/6a25a61d5216
Store globals in baseline compiler r=jandem
https://hg.mozilla.org/integration/autoland/rev/e9af2693fdfe
Generate DebugTrapHandler earlier r=jandem

Comment 11

[Iain Ireland [:iain]]

Attachment: Bug 1930281: Allow BaselinePerfSpewer::recordInstruction to be used off-thread r=jandem

Comment 12

[Iain Ireland [:iain]]

Attachment: Bug 1930281: Hoist OOM reporting outward r=jandem

Comment 13

[Iain Ireland [:iain]]

Attachment: Bug 1930281: Refactor compilerWarmUpThreshold r=jandem

Comment 14

[Iain Ireland [:iain]]

Attachment: Bug 1930281: Remove cx field from BaselineCodeGen r=jandem

Comment 15

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/4b1ed4ac7afa
https://hg.mozilla.org/mozilla-central/rev/31ca9b2fa3a5
https://hg.mozilla.org/mozilla-central/rev/9c0e67cd9404
https://hg.mozilla.org/mozilla-central/rev/6a25a61d5216
https://hg.mozilla.org/mozilla-central/rev/e9af2693fdfe

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85ffdbd82112
Allow BaselinePerfSpewer::recordInstruction to be used off-thread r=jandem
https://hg.mozilla.org/integration/autoland/rev/864a95c0cbf8
Hoist OOM reporting outward r=jandem
https://hg.mozilla.org/integration/autoland/rev/159e5286ec2a
Refactor compilerWarmUpThreshold r=jandem
https://hg.mozilla.org/integration/autoland/rev/bf9fe518cd1a
Remove cx field from BaselineCodeGen r=jandem

Comment 17

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/85ffdbd82112
https://hg.mozilla.org/mozilla-central/rev/864a95c0cbf8
https://hg.mozilla.org/mozilla-central/rev/159e5286ec2a
https://hg.mozilla.org/mozilla-central/rev/bf9fe518cd1a

Comment 18

[Iain Ireland [:iain]]

Attachment: Bug 1930281: Use external macroassembler in BaselineCodeGen r=jandem

StackMacroAssembler can only be stack-allocated on the main thread, so we need to be able to use a different MacroAssembler that can enforce GC safety off-thread (similarly to IonHeapMacroAssembler).

I wanted to put a StackMacroAssembler as a member of BaselineInterpreterGenerator, to avoid having to allocate one at the call site. However, it was uninitialized in the BaselineCodeGen construtor, because derived class fields are initialized after calling the superclass constructor.

Comment 19

[Iain Ireland [:iain]]

Attachment: Bug 1930281: Remove cx argument from BaselineCodeGen r=jandem