Closed Bug 1930302 Opened 1 year ago Closed 1 year ago

Fenix address bar changes to show non-navigable URL when tapping certain external-app-launching links

Categories

(Firefox for Android :: Browser Engine, defect, P1)

All
Android
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox132 --- unaffected
firefox133 + disabled
firefox134 + disabled

People

(Reporter: dholbert, Assigned: calu)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fxdroid][group4])

Attachments

(2 files)

Steps to reproduce

  1. Be sure you don't have the Instagram native app installed. (Uninstall it, if you've got it.) EDIT: disregard this step - on further testing, I found this isn't necessary -- this bug reproduces regardless of whether or not Instagram-the-app is installed.
  2. Visit https://instagram.com in Firefox Nightly on Android.
  3. Tap the big "Open in Instagram" button. (This will probably launch the Google Play store.)
  4. Switch apps back to Firefox.

Expected behavior

URL bar should still show instagram.com

Actual behavior

URL bar shows intent://instagram.com/_n/m... (can't see the rest of it after that, but the full URL can be seen if you tap the address bar -- it's quite long)

Device information

  • Firefox version: Nightly 134.0a1
  • Android device model: Pixel 6a, Pixel 8
  • Android OS version: 15

Any additional information?

This seems to be a regression, with regression range https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ea780f8940f5&tochange=8301e6902b9a

In there, I suspect bug 1914797 as having caused this change, since it had to do with the timing/logic around updates to what we show in the address bar during navigation.

See Also: → 1930300

(In reply to Daniel Holbert [:dholbert] from comment #0)

  1. Be sure you don't have the Instagram native app installed. (Uninstall it, if you've got it.)

I just updated comment 0 to strike this out -- this bug reproduces if you've got the app installed, too.

(I had previously noticed that the bug reproduces and is extra-noticeable when you have the Instagram app installed-but-never-yet-launched, because then you hit bug 1930300 and the address-bar-change ends up being the only thing that you see. I just confirmed it reproduces when you have the Instagram app installed and launched/functional, too.)

Attachment #9436580 - Attachment description: screencast of bug (notice the address bar contents changing right away when I tap the "open in instagram" button) → screencast of bug reproducing when Instagram is not installed (notice the address bar contents changing right away when I tap the "open in instagram" button)
Summary: Fenix address bar changes to show "intent://" URL when tapping certain in-app links → Fenix address bar changes to show "intent://" URL when tapping certain external-app-launching links
Severity: -- → S2
Flags: needinfo?(calu)
Priority: -- → P1
Whiteboard: [fxdroid][group4]
Assignee: nobody → calu
Summary: Fenix address bar changes to show "intent://" URL when tapping certain external-app-launching links → Fenix address bar changes to show non-navigable URL when tapping certain external-app-launching links

Setting Fx133 to disabled since the regressing patch in Bug 1914797 was backed out of beta.

Reproducible with Aliexpress. At first, everything is normal, then Aliexpress tries to force app load with the aliexpress:// URI scheme on every page, trying to redirect to the corresponding app activity. "Open links in app" is disabled in Fenix settings. As a result, the URL changes to a string such as aliexpress://product/detail?productId= that is of no practical use, though the page is not redirected to app.

(In reply to killercontact1.7.4.0 from comment #7)

Reproducible with Aliexpress. At first, everything is normal, then Aliexpress tries to force app load with the aliexpress:// URI scheme on every page, trying to redirect to the corresponding app activity. "Open links in app" is disabled in Fenix settings. As a result, the URL changes to a string such as aliexpress://product/detail?productId= that is of no practical use, though the page is not redirected to app.

P.S. it is not disabled, set to "always ask", but the dialog never shows on Aliexpress.

If Firefox is showing you aliexpress:// in Firefox's URL bar at all, then that specific cosmetic issue is this bug.[1] If you're seeing additional odd/unexpected behavior while using the Aliexpress webapp, then that's probably worth filing a new bug for with more details. (please do - thanks!)

(If I understand you correctly, you're expecting to see an open-in-app dialog, but you're not getting one. If so, that's neither Bug 1882137 nor this bug here; hence, a new bug would be good. Bug 1882137 is tangentially about these dialogs -- specifically about what happens if you cancel out of them, which is different from what you're talking about, I think.)

[1] For what it's worth I'm not yet seeing "Aliexpress tries to force app load with the aliexpress:// URI scheme on every page" in my own Firefox Nightly on Android, unless I explicitly tap the "open" bar on the site's "install our app" banner, which causes an aliexpress:// URI to briefly flash in my URL bar. But if you & I are seeing different behaviors from the site, it's conceivable that that's just geolocation-dependent, or login-dependent (I'm not logged in), or there's some other external factor involved. Anyway, probably not worth trying to sort out the difference in observed behavior here; those sorts of details would be great to sort out on the bug report that you'll perhaps file about this.

Setting Fx134 to disabled since the regressing patch in Bug 1914797 was backed out of central.

This should be resolved by the patch being backed out. Closing as WORKSFORME.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: