Closed Bug 1930352 Opened 3 days ago Closed 3 days ago

Typo error in Import translations from android-l10n causing lint and browser-errorpages perma failures

Categories

(Fenix :: Translations, defect)

Product:
Fenix
Component:
Translations
Platform:
All
Android
Type:
defect

Tracking

(firefox134 fixed)

Status:
RESOLVED FIXED
Milestone:
134 Branch
Tracking Flags:
Tracking Status
firefox134 --- fixed

People

(Reporter: SerbanS, Assigned: smolnar, NeedInfo)

Details

Failure summary is missing.
This started to fail once android-l10n bump landed on autoland, as it can be seen here and here.

Summary: Typo error in Import translations from android-l10n r=release a=l10n causing lint and browser-errorpages perma failures → Typo error in Import translations from android-l10n causing lint and browser-errorpages perma failures

The Bugbug bot thinks this bug should belong to the 'Fenix::Translations' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Translations
Pushed by smolnar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/38bb2480e796 Fix android lint failure. a=lint-fix CLOSED TREE
Pushed by smolnar@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/4731e8f82127 Fix android lint failure. a=lint-fix CLOSED TREE

https://hg.mozilla.org/mozilla-central/rev/4731e8f82127

Status: NEW → RESOLVED
Closed: 3 days ago
status-firefox134: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch

Not sure if something needs to land upstream in Pontoon still here.

Flags: needinfo?(lebedel.delphine)
Assignee: nobody → smolnar

Fixing autoland is going to fix an issue in localized strings only for ~12h.

With that said, I thought we discussed this a couple of months ago and that we shouldn't fail for "typos" in localized strings (most are false positive, and we cannot tag strings to have the plugin ignore them)

This started to fail once android-l10n bump landed on autoland

Did anything change in CI? Norwegian has already a bug on file for previous strings: https://bugzilla.mozilla.org/show_bug.cgi?id=1919514

  1. Can localized files be excluded from Gradle's checks for typos? Matching the folders is easy (values-*, while English is in values).
  2. If not, can we disable "typos" in Gradle's config? Or change it to a warning?

As mentioned, Ryan filed a few bugs, 2 of them are still open, but 4 were false positive.

So, why is this starting to fail now?

In the meantime, I've updated the string in Pontoon to spare sheriffs' the task to keep changing this string (it will take probably one more round).

You need to log in before you can comment on or make changes to this bug.