Fix too much recursion and missing variable in cmdSave in cZ
Categories
(SeaMonkey :: Chat, defect)
Tracking
(seamonkey2.53? affected)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
|
2.81 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
STR
1/ Start cZ
2/ Connect to a server and join a channel
3/ Use /save to try to save to an area which will error (e.g. /save file:///test.txt)
Expected result
Error message on output screen
Actual result
Error in stdout of "too much recursion" and "ReferenceError: aMessage is not defined"
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: no feedback when /save errors
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
When /save errors need to clear progressListener otherwise cancelSave loops back to the same code.
Fix up QueryInterface to use XPCOMUtils.generateQI whilst here.
|
||
Updated•2 months ago
|
|
|
||
Comment 2•2 months ago
|
||
Comment on attachment 9436635 [details] [diff] [review]
1930391-irc-fix-cmdSave-25320.patch
lgtm r/a+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/1ccf53aba444
Fix too much recursion and missing variable in cmdSave in cZ. r=frg
Description
•