Closed
Bug 1930396
Opened 2 months ago
Closed 2 months ago
Replace confirm helper with Services.prompt.confirm in cZ
Categories
(SeaMonkey :: Chat, task)
SeaMonkey
Chat
Tracking
(seamonkey2.53? affected)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
|
6.42 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
Rather than having a helper in utils.js just make use of Services.prompt.confirm
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9436638 -
Flags: review?(frgrahl)
Attachment #9436638 -
Flags: approval-comm-release?
|
||
Updated•2 months ago
|
|
|
||
Comment 2•2 months ago
|
||
Comment on attachment 9436638 [details] [diff] [review]
1930396-irc-prompt-confirm-25320.patch
lgtm r/a+
Was the previous code correct? Seems it did always set the title as parentwindow for the confirm?
Attachment #9436638 -
Flags: review?(frgrahl)
Attachment #9436638 -
Flags: review+
Attachment #9436638 -
Flags: approval-comm-release?
Attachment #9436638 -
Flags: approval-comm-release+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b910e0b5b928
Replace confirm helper with Services.prompt.confirm in cZ. r=frg
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•