1930472 - Crash in [@ RtlInitUnicodeStringEx | LoadLibraryExW]

Status: RESOLVED FIXED

(External Software Affecting Firefox :: Other, defect, P1)

Description

[Bob Owen (:bobowen) (PTO until 5th Oct)]

Found during USER_RESTRICTED experiment.
Crash pings from 05-10 Nov: clients 7, crashes 53.
All similar crashes on crash-stats have module: TbdgHook64.dll that is from TubeDigger a streaming media downloader.
It looks like it is trying to load a DLL.
The same version (1.5.9.0) appears to be in all crashes on crash-stats, so I'll block that version and before because for content we have to block for all child processes at the moment.
We appear to get this issue without USER_RESTRICTED as well, but it's possibly been made more frequent.

Crash report: https://crash-stats.mozilla.org/report/index/ff681dd3-b81d-4549-8c9f-250ec0241106

Reason:

EXCEPTION_ACCESS_VIOLATION_READ

Top 6 frames:

0  ntdll.dll  RtlInitUnicodeStringEx
1  KERNELBASE.dll  LoadLibraryExW
2  kernel32.dll  BaseThreadInitThunk
3  mozglue.dll  mozilla::interceptor::FuncHook<mozilla::interceptor::WindowsDllInterceptor<mo...  toolkit/xre/dllservices/mozglue/nsWindowsDllInterceptor.h:150
3  mozglue.dll  patched_BaseThreadInitThunk(int, void*, void*)  toolkit/xre/dllservices/mozglue/WindowsDllBlocklist.cpp:562
4  ntdll.dll  RtlUserThreadStart

Comment 1

[Bob Owen (:bobowen) (PTO until 5th Oct)]

Many of the crashes in the stats are from failed loads in the parent process, there are a variety of third-party modules in those cases.

Comment 2

[Bob Owen (:bobowen) (PTO until 5th Oct)]

Attachment: Bug 1930472: Block TubeDigger DLLs (TbdgHook[64].dll) in all child processes to avoid crashes. r=gstoll!

Only blocking the latest version because we cannot currently just block content
and there does not appear to be crashes in other process types.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92dc83a48861
Block TubeDigger DLLs (TbdgHook[64].dll) in all child processes to avoid crashes. r=gstoll,win-reviewers

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/92dc83a48861

Comment 5

[Bob Owen (:bobowen) (PTO until 5th Oct)]

Attachment: Bug 1930472: Block TubeDigger DLLs (TbdgHook[64].dll) in all child processes to avoid crashes. r=gstoll!

Only blocking the latest version because we cannot currently just block in
content and there does not appear to be crashes in other process types.

Original Revision: https://phabricator.services.mozilla.com/D228600

Comment 6

[Bob Owen (:bobowen) (PTO until 5th Oct)]

Attachment: Bug 1930472: Block TubeDigger DLLs (TbdgHook[64].dll) in all child processes to avoid crashes. r=gstoll!

Only blocking the latest version because we cannot currently just block in
content and there does not appear to be crashes in other process types.

Original Revision: https://phabricator.services.mozilla.com/D228600

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Content crashes for people using TubeDigger
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: Adding current verison of a DLL to blocklist.
• String changes made/needed: None
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/dbcf931c4caf