1930576 - Display metrics in storage on about:glean

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P4)

Description

[Bruno Rosa [:brosa]]

Fetch existing metric data in storage and display it in a table on the page.

• Can get all the categories by iterating over Glean
• Can get all metric names by iterating over all categories via Glean.<category>
• Can get all metric values by calling testGetValue on all metrics

For this implementation, we will ignore labeled metrics. Adding a testGetValue for labeled metrics will happen separately in https://bugzilla.mozilla.org/show_bug.cgi?id=1930572

Comment 1

[Charlie Humphreys [:charlie] [:jeddai]]

Attachment: Bug 1930576: add table to about:glean listing each metric, its type, and value r?chutten

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8191767b8ac2
https://hg.mozilla.org/integration/autoland/rev/fe3c24f7c6c1
add table to about:glean listing each metric, its type, and value r=chutten,fluent-reviewers,toolkit-telemetry-reviewers,bolsson

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0cb1556cc236
https://hg.mozilla.org/integration/autoland/rev/77467ca3f20d
Revert "Bug 1930576: add table to about:glean listing each metric, its type, and value r=chutten,fluent-reviewers,toolkit-telemetry-reviewers,bolsson" for causing failures complaining about aboutGlean.js.

Comment 4

[Atila Butkovits]

Backed out for causing failures complaining about aboutGlean.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/77467ca3f20d607a51c8a80035ad1ff642c9b59b

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=fe3c24f7c6c166ed288593a7efeae02811ad9426&selectedTaskRun=YrnteSJiQz6XBglp-9XKeQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=523263630&repo=autoland&task=YrnteSJiQz6XBglp-9XKeQ.0&lineNumber=2190

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a52f3f39493f
https://hg.mozilla.org/integration/autoland/rev/3a5c58bcc40b
add table to about:glean listing each metric, its type, and value r=chutten,fluent-reviewers,toolkit-telemetry-reviewers,bolsson

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5112104251fc
https://hg.mozilla.org/integration/autoland/rev/d6d5047a9ac2
Revert "Bug 1930576: add table to about:glean listing each metric, its type, and value r=chutten,fluent-reviewers,toolkit-telemetry-reviewers,bolsson" for causing bc failures on browser_parsable_css and browser_all_files_referenced

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for causing bc failures on browser_parsable_css and browser_all_files_referenced

Push with failures

Failure logs:

• browser/base/content/test/static/browser_parsable_css.js | Got error message for chrome://global/content/aboutGlean.css: Error in parsing value for ‘vertical-align’. Declaration dropped. - https://treeherder.mozilla.org/logviewer?job_id=523335460&repo=autoland&task=Bc28Nit_RESYcaraU2nVOw.0
• browser/base/content/test/static/browser_all_files_referenced.js | unused allowlist entry: chrome://global/content/third_party/d3/d3.js - https://treeherder.mozilla.org/logviewer?job_id=523340118&repo=autoland&task=T2hBe7gJRo6rO9xR_dqqmA.0

Backout link

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2965121e964b
https://hg.mozilla.org/integration/autoland/rev/426245dbc609
add table to about:glean listing each metric, its type, and value r=chutten,fluent-reviewers,toolkit-telemetry-reviewers,bolsson

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/426245dbc609