1930643 - Decide what to do with `alerts.showFavicons`

Status: RESOLVED FIXED

(Toolkit :: Alerts Service, task)

Description

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

This pref has been there since 2016 but always been disabled by default. Currently it's only implemented in XUL (via nsIAlertsIconURI) and macOS backend (via nsIAlertsIconData).

• Check if it still works
• Investigate whether it's possible to implement on other backends (probably not for Windows, maybe for libnotify)

Comment 1

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1930643 - Part 1: Remove all warnings in nsAlertsService.cpp/h r=nalexander,nrishel

Comment 2

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1930643 - Part 2: Remove favicon support from nsAlertsService r=nalexander,nrishel

Note that this has nothing to do with Notification.icon even though the code mentions icon.

Comment 3

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1930643 - Part 3: Remove icon support from XULAlerts r=nalexander,nrishel

Comment 4

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1930643 - Part 4: Remove icon support from OSXNotificationCenter r=#mac-reviewers

No other browser shows favicon on notifications, and even though the the latest macOS 15.3.2 passes the condition to enter the block, it does not make any actual visual change anymore.

Depends on D241434

Comment 5

[Gregory Pappas [:gregp]]

These prefs are removed:

• alerts.showFavicons

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9b608e3f5be
Part 1: Remove all warnings in nsAlertsService.cpp/h r=nalexander
https://hg.mozilla.org/integration/autoland/rev/998362f750db
Part 2: Remove favicon support from nsAlertsService r=nalexander
https://hg.mozilla.org/integration/autoland/rev/696af1aae0e9
Part 3: Remove icon support from XULAlerts r=nalexander
https://hg.mozilla.org/integration/autoland/rev/212cfcc12afa
Part 4: Remove icon support from OSXNotificationCenter r=nalexander

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b9b608e3f5be
https://hg.mozilla.org/mozilla-central/rev/998362f750db
https://hg.mozilla.org/mozilla-central/rev/696af1aae0e9
https://hg.mozilla.org/mozilla-central/rev/212cfcc12afa