1930650 - The weather suggestion for a city is no longer displayed if the suggestion for that city was previously clicked

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

[Affected versions]:

• Firefox Beta 133.0b7 (Build ID: 20241111092015)

[Affected Platforms]:

• Windows 10 x64
• Ubuntu 20.04 x64
• macOS 12.6.1

[Prerequisites]:

• Have the Firefox Beta 133 en-* build installed.
• Set browser.search.region pref to US. (mandatory use of a VPN client if non-US user).
• Windows ONLY: Set browser.urlbar.weather.ignoreVPN pref to true.
• Set browser.urlbar.weather.featureGate pref to true.
• Set browser.urlbar.suggest.quicksuggest.sponsored pref to true.
• Set browser.urlbar.suggest.weather pref to true.
• Have the OS language set to English (US).

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Type the “miami” keyword in the Address Bar.
3. Click the weather suggestion for Miami.
4. Focus the Address Bar and type “miami” again.
5. Observe the behavior.

[Expected result]:

• The weather suggestion for Miami is displayed again.

[Actual result]:

• The weather suggestion for Miami is NOT displayed.

[Notes]:

• Only the history results are displayed in the Firefox Suggest sections.
• Here is the error from the Browser Console when typing a city name which was previously clicked:
  TypeError: rawUrl: undefined UniFFI.sys.mjs:23:5 URLBar - ProvidersManager: TypeError: rawUrl: undefined UniFFITypeError resource://gre/modules/UniFFI.sys.mjs:23 checkType resource://gre/modules/RustSuggest.sys.mjs:249 checkType resource://gre/modules/RustSuggest.sys.mjs:403 functionCall resource://gre/modules/RustSuggest.sys.mjs:2827 rawSuggestionUrlMatches resource://gre/modules/RustSuggest.sys.mjs:2848 isURLEquivalentToResultURL resource:///modules/QuickSuggest.sys.mjs:384 _canAddResult resource:///modules/UrlbarMuxerUnifiedComplete.sys.mjs:965 _addResults resource:///modules/UrlbarMuxerUnifiedComplete.sys.mjs:658 _fillGroup resource:///modules/UrlbarMuxerUnifiedComplete.sys.mjs:324 _fillGroupChildren resource:///modules/UrlbarMuxerUnifiedComplete.sys.mjs:413 _fillGroupChildren resource:///modules/UrlbarMuxerUnifiedComplete.sys.mjs:436 _fillGroup resource:///modules/UrlbarMuxerUnifiedComplete.sys.mjs:323 _fillGroupChildren resource:///modules/UrlbarMuxerUnifiedComplete.sys.mjs:413 _fillGroup resource:///modules/UrlbarMuxerUnifiedComplete.sys.mjs:323 _fillGroupChildren resource:///modules/UrlbarMuxerUnifiedComplete.sys.mjs:413 _fillGroup resource:///modules/UrlbarMuxerUnifiedComplete.sys.mjs:323 _fillGroupChildren resource:///modules/UrlbarMuxerUnifiedComplete.sys.mjs:413 _fillGroup resource:///modules/UrlbarMuxerUnifiedComplete.sys.mjs:323 sort resource:///modules/UrlbarMuxerUnifiedComplete.sys.mjs:185 _notifyResults resource:///modules/UrlbarProvidersManager.sys.mjs:775 callback resource:///modules/UrlbarProvidersManager.sys.mjs:758 promise resource:///modules/UrlbarUtils.sys.mjs:2882 UrlbarProvidersManager.sys.mjs:677:56
• Here is a screen recording of the issue.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1930650 - Fix an error with how Suggest compares URLs to weather suggestions.

The error reported in the bug is thrown when isURLEquivalentToResultURL()
passes an undefined originalUrl to rawSuggestionUrlMatches() as the muxer is
comparing a history result to the weather result. Weather result payloads don't
include originalUrl, but isURLEquivalentToResultURL() assumes that all Rust
suggestions have it.

This patch modifies isURLEquivalentToResultURL() so it doesn't make that
assumption. Other places that access originalUrl also do not assume it's
defined, so I think this is just a mistake in isURLEquivalentToResultURL().
Alternatively, we could make sure originalUrl is always defined on all
payloads, or maybe only Rust payloads, but that would require updating several
tests, and I like the idea that results only include it when necessary.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad4c6be9d5db
Fix an error with how Suggest compares URLs to weather suggestions. r=daisuke

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ad4c6be9d5db

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:adw, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 134.0a1 (Build ID 20241115093447) on Windows 10, macOS 12.6.1, and Ubuntu 20.04 x64.

• The weather suggestion for the city that was previously clicked is displayed again after typing the name of the city in the urlbar.

Comment 6

[Drew Willcoxon :adw]

Not planning on uplifting this.