Closed Bug 1930780 Opened 2 years ago Closed 1 year ago

ruff: testing/parse_reftest.py: Replace `if` statement with `first = min(i, first)`

Categories

(Developer Infrastructure :: Lint and Formatting, task)

task

Tracking

(firefox137 fixed)

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- fixed

People

(Reporter: Sylvestre, Assigned: firefox.flashy254, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=python])

Attachments

(1 external file)

Filling as a good first bug to learn workflows.

Replace if statement with first = min(i, first) PLR1730 (ruff)

https://searchfox.org/mozilla-central/source/testing/parse_reftest.py#457-458

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by https://docs.astral.sh/ruff/rules/if-stmt-min-max/

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Assignee: nobody → firefox.flashy254
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a9473ead9849 Changed `if` statement with `first = min(i, first)` r=sylvestre DONTBUILD

Do you want more good first bugs? :)

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch

Yes please!

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: