show_bug.cgi is using subframe scrolling again
Categories
(bugzilla.mozilla.org :: User Interface, defect)
Tracking
()
People
(Reporter: botond, Assigned: u232883)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
In bug 1656609, the page structure of show_bug.cgi was changed so that the scrolling element is the root (<html> element), not a descendant.
It looks like this has been regressed. I think the regressing change is bug 1904321 (at least, I see the diff for that change adding overflow: auto to #bugzilla-body and I don't see that there before).
I believe the motivations for keeping <html> the scrolling element that were outlined in bug 1656609 comment 0 and bug 1656609 comment 3 remain valid, so it would be nice to keep that structure.
|
||
Updated•7 months ago
|
There are many sites and apps that use subframe scrolling, including Jira and Chromium Issue Tracker, so I don’t think Bugzilla has any particular reason to avoid it. I actually tried to keep the previous structure in Bug 1904321 but ran into some problems (I can’t remember exactly) so decided to switch to subframe scrolling.
This also makes it easier for Bugzilla to switch to a two-column layout in the future, as I proposed a long time ago in Bug 1330451. (I recently proposed the layout change to :glob after seeing the Monorail migration, but it’s not part of my current contract.)
I’m a long-time Magic Trackpad user — I don’t have a mouse — and I occasionally pinch-and-zoom in Firefox. It’s nice. But I think pinch-and-zoom is mainly for temporarily zooming in on a page and that doesn’t happen very often especially on desktop.
(In reply to Kohei Yoshino from comment #1)
This also makes it easier for Bugzilla to switch to a two-column layout in the future, as I proposed a long time ago in Bug 1330451. (I recently proposed the layout change to :glob after seeing the Monorail migration, but it’s not part of my current contract.)
This alone isn't a reason not to make this change; switching to a two-column layout isn't on our roadmap in the foreseeable future.
|
||
Comment 3•7 months ago
|
||
(In reply to Botond Ballo [:botond] from comment #0)
I believe the motivations for keeping
<html>the scrolling element that were outlined in bug 1656609 comment 0 and bug 1656609 comment 3 remain valid
I think bug 1928009 is actually the more convincing argument - dynamic toolbars won't hide unless this change is made.
(In reply to Kohei Yoshino from comment #1)
I actually tried to keep the previous structure in Bug 1904321 but ran into some problems (I can’t remember exactly) so decided to switch to subframe scrolling.
I see enough compelling reasons across bug 1656609 and bug 1928009 for you to revisit addressing this issue; at the least to document the issues you encountered.
|
||
Comment 6•7 months ago
|
||
|
|
||
Comment 7•7 months ago
|
||
Description
•