1930848 - Log instead of throwing when responseCompleted is skipped due to a missing responseStarted event

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Julian Descottes [:jdescottes]]

At the moment, we have relatively frequent log pollution due to network events which are missing the responseStarted event. This usually shows up in the logs as

JavaScript error: chrome://remote/content/shared/listeners/NetworkEventRecord.sys.mjs, line 328: TypeError: can't access property "setResponseSizes", this[#response] is null

We should investigate individual cases which lead to missing events, but at the moment we don't even log the URL of the skipped event, so it makes it difficult to investigate.

I suggest to add a guard at https://searchfox.org/mozilla-central/rev/55837bbe3e47f9b4fa91ef83a44b53823626f01d/remote/shared/listeners/NetworkEventRecord.sys.mjs#328

this.#response.setResponseSizes(sizes);

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Patrick Shannon]

Hey! Looking for my first contribution, have 5 years JS and backend experience. Seems like an easy first contribution, if it is still up for grabs.

I am looking to build up my opensource contributions!

Comment 3

[Julian Descottes [:jdescottes]]

(In reply to Patrick Shannon from comment #2)

Hey! Looking for my first contribution, have 5 years JS and backend experience. Seems like an easy first contribution, if it is still up for grabs.

I am looking to build up my opensource contributions!

Hi Patrick!

Yes it's still available, just submit a patch and the bug will automatically be assigned to you. Our getting started docs should cover everything you need to do that: https://firefox-source-docs.mozilla.org/setup/index.html , but if you need help feel free to reach out on https://chat.mozilla.org

Comment 4

[Patrick Shannon]

Attachment: Bug 1930848 - [remote]Improve logging in NetworkEventRecord for cases where missing response info. Added warning log with skipped request url. r=jdescottes

Comment 5

[Patrick Shannon]

Attachment: Bug 1930848 - Added logger, removed some comments. r=jdescottes

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/feed28df23eb
[remote]Improve logging in NetworkEventRecord for cases where missing response info. Added warning log with skipped request url. r=jdescottes,webdriver-reviewers

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/feed28df23eb