1930929 - Pinned tabs are not moved correctly by drag and drop in vertical tabs when the tabs overflow

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: sidebar.gif

Found in

• 134.0a1 (2024-11-12)

Affected versions

• 134.0a1 (2024-11-12)
• 133.0b7

Tested platforms

• Affected platforms: Windows 10, macOS 12, Ubuntu 24
• Unaffected platforms: none

Precognitions

• sidebar.revamp:true
• vertical tabs enabled

Steps to reproduce

1. Pin multiple tabs until the pinned tabs overflow.
2. Drag a pined tab down or up.

Expected result

• The pinned tab can be moved when the tabs overflow.

Actual result

• The pinned tab is no longer displayed after being dragged to the end of the displayed list.

Regression range

• Not a regression. Reproducible with builds after drag and drop was fixed inside vertical tabs (bug 1893656)

Additional notes

• Attached a screen recording.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Your thoughts on the priority on this one Ania?

Comment 2

[Nikki Sharpley (:nikkis) (she/her)]

Fixed as part of Bug 1926831

Comment 3

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: drag_pinned_tabs.gif

Hello! I tried verifying this issue today, but it seems that after following the steps from comment 0, the issue is still present with Firefox 134.0a1 (2024-11-24) on Windows 10x64, macOS 12, and Ubuntu 24 (see screen recording). I will reopen this issue. Thank you!

Comment 4

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1930929 - Fix vertical pinned tabs drag animation on scroll overflow r=#tabbrowser-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dff48f0a2c9d
Fix vertical pinned tabs drag animation on scroll overflow r=tabbrowser-reviewers,dao

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/dff48f0a2c9d

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nsharpley, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: 1930929_0.gif

Hello! I tried to verify the issue today but it seems that that are two issues present here with Firefox 135.0a1 (2024-12-02) on Windows 10x64:

• the first one is that if the mouse is not moved after dragging the pined tab on the bottom side the pinned tab will be hidden when the overflow is scrolled until the mouse is moved again
• The second issue is that bottom pinned tabs cannot be dragged
  Please see the attached screen recording for both of the issues.
  Should we reopen this issue or file another two issues independently? Thank you!

Comment 9

[Nikki Sharpley (:nikkis) (she/her)]

Thanks :atrif! I think the first might be an existing bug (or expected?) as I can reproduce the behaviour on scrolling horizontal tabs that aren't pinned. The second is a new bug we should file. Thanks for catching that!

Comment 10

[Nikki Sharpley (:nikkis) (she/her)]

:atrif, follow up bug filed and fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=1935026

Comment 11

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Thank you! Based on the above comments, the issue is verified with Firefox 135.0a1 (2024-12-05) on Windows 10x64, macOS 12 and Ubuntu 24. The pinned tabs are correctly moved in vertical mode by drag and drop when overflowing.