1930975 - Linter warnings in Actions.sys.mjs for: "warning 'action' is already declared in the upper scope on line 42 column 14"

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Running the linter on remote/shared/webdriver/Actions.sys.mjs I get quite a couple of linter warnings:

  1934:27  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)
  1999:28  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)
  2006:38  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)
  2029:21  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)
  2076:28  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)
  2082:38  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)
  2132:36  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)
  2203:22  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)
  2218:30  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)
  2446:41  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)
  2498:39  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)
  2535:41  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)
  2674:16  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)
  2705:58  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)
  2733:16  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)
  3031:36  warning  'action' is already declared in the upper scope on line 42 column 14.  no-shadow (eslint)

Those exist because the module name that we export is named action as well. We should update the code in all these lines to not use action but some other similar name.

Comment 1

[Spencer]

I would like to take up this bug if it's still available!

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yes, it's still free to take. Thanks!

Comment 3

[Spencer]

Attachment: Bug 1930975 - [WebDriver] Renamed 'action' params in Actions.sys.mjs to avoid conflict with 'action' module. r=whimboo

-'action' parameters with warning flags from mach linter in Actions.sys.mjs have been
renamed to 'eventAction' along with refs to avoid a naming conflict with the module of the same name.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd57b86d4773
[WebDriver] Renamed 'action' params in Actions.sys.mjs to avoid conflict with 'action' module. r=whimboo,webdriver-reviewers

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/dd57b86d4773