1930980 - Tcl/Tk hooks deprecated in new PyInstaller

Status: RESOLVED FIXED

(Testing :: mozregression, defect, P2)

Description

[Zeid [:zeid]]

PyInstaller 6.10 (the first to support Python 3.13) deprecates certain methods in PyInstaller.utils.hooks.tcl_tk that are used in mozregression, causing errors during builds. For example:

Traceback (most recent call last):
  File "/Users/runner/work/mozregression/mozregression/env/bin/pyinstaller", line 8, in <module>
    sys.exit(_console_script_run())
             ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/work/mozregression/mozregression/env/lib/python3.12/site-packages/PyInstaller/__main__.py", line 231, in _console_script_run
    run()
  File "/Users/runner/work/mozregression/mozregression/env/lib/python3.12/site-packages/PyInstaller/__main__.py", line 215, in run
    run_build(pyi_config, spec_file, **vars(args))
  File "/Users/runner/work/mozregression/mozregression/env/lib/python3.12/site-packages/PyInstaller/__main__.py", line 70, in run_build
    PyInstaller.building.build_main.main(pyi_config, spec_file, **kwargs)
  File "/Users/runner/work/mozregression/mozregression/env/lib/python3.12/site-packages/PyInstaller/building/build_main.py", line 1227, in main
    build(specfile, distpath, workpath, clean_build)
  File "/Users/runner/work/mozregression/mozregression/env/lib/python3.12/site-packages/PyInstaller/building/build_main.py", line 1167, in build
    exec(code, spec_namespace)
  File "gui.spec", line 4, in <module>
    from mozregression.pyinstaller import BUNDLE_WITH_TK
  File "/Users/runner/work/mozregression/mozregression/mozregression/pyinstaller.py", line 16, in <module>
    from PyInstaller.utils.hooks.tcl_tk import (
ImportError: cannot import name '_collect_tcl_modules' from 'PyInstaller.utils.hooks.tcl_tk' (/Users/runner/work/mozregression/mozregression/env/lib/python3.12/site-packages/PyInstaller/utils/hooks/tcl_tk.py)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:zeid, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[BMO Github Automation]

Attachment: [mozilla/mozregression] gui: pyinstaller fixes (bug 1930980) (#2051)