Closed
Bug 1930983
Opened 3 months ago
Closed 3 months ago
Remove unused test-only ServiceWorkerContainer.getScopeForUrl helper
Categories
(Core :: DOM: Service Workers, task)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
134 Branch
| Tracking | Status | |
|---|---|---|
| firefox134 | --- | fixed |
People
(Reporter: asuth, Assigned: asuth)
References
Details
Attachments
(1 file)
We have a test-only method ServiceWorkerContainer.getScopeForUrl which is orphaned. When initially filing the bug I thought we used it in a test, but in fact we're only using the underlying nsIServiceWorkerManager::getScopeForUrl.
The test using nsIServiceWorkerManager is testing test scope logic which seems like it could be a fairly simple gtest unit test if we wanted, although the XPIDL interface exposure and usage is fairly harmless. The other checks in test_scopes.html relating to calls to register would not be appropriate for a gtest, although I suspect we get the coverage from WPTs already.
|
Assignee | |
Updated•3 months ago
|
Assignee: nobody → bugmail
Status: NEW → ASSIGNED
Summary: Remove test-only ServiceWorkerContainer.getScopeForUrl helper and replace existing usage with a gtest → Remove test-only ServiceWorkerContainer.getScopeForUrl helper
|
|
Assignee | |
Updated•3 months ago
|
Summary: Remove test-only ServiceWorkerContainer.getScopeForUrl helper → Remove unused test-only ServiceWorkerContainer.getScopeForUrl helper
|
|
Assignee | |
Comment 1•3 months ago
|
||
Pushed by bugmail@asutherland.org:
https://hg.mozilla.org/integration/autoland/rev/bb219800bc23
Remove unused test-only ServiceWorkerContainer.getScopeForUrl helper. r=saschanaz,dom-worker-reviewers,webidl,edenchuang
|
||
Comment 3•3 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox134:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•