Open Bug 1931217 Opened 21 days ago Updated 21 days ago

Replace nsIMsgDatabase.markOffline() with a better interface (which also handles .storeToken and message size attrs)

Categories

(MailNews Core :: General, task)

Tracking

(Not tracked)

People

(Reporter: benc, Unassigned)

Details

nsIMsgDatabase.markOffline() currently deals with the Offline flag and nothing else. But the Offline flag is useless by itself without at least a storeToken. It seems dangerous to encourage such dependent values to be updated independently.

This interface should probably be split in two. Something like:

registerOfflineMsg(key, storeToken, size)  // set Offline flag, storeToken and size all in one go
discardOfflineMsg(key)  // clear Offline flag, clear storeToken, zero the size

All the nsIMsgDatabase.mark* methods seem to deal exclusively with message flags. Offline requires more than just the flag.

You need to log in before you can comment on or make changes to this bug.