1931237 - debug_file in stack traces written by minidump-analyzer on Linux have full filepaths rather than the basename

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Alex Franchuk [:afranchuk]]

Telemetry shows this coincides with the new minidump-analyzer landing in bug 1743983. This seems to only affect Linux: other platforms only have the base filename. This was discovered because the symbolication server rejects the debug_files if they are the full paths.

Comment 1

[Alex Franchuk [:afranchuk]]

The minidump-analyzer doesn't change anything about the module debug file which comes from the rust-minidump crates, so the platform differences stem there. It's likely that this is a nuance of the rust-minidump implementation, and it should be find to strip away the resulting path to be the basename to match the old behavior.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1743983

Comment 3

[Donal Meehan [:dmeehan]]

:afranchuk could you add a severity on this when you have a moment?

Comment 4

[Alex Franchuk [:afranchuk]]

S3 because this prevents us from symbolicating Linux crash ping stacks, but there is a workaround on the server side (taking the basename of the debug path). Otherwise I would say S2.

Comment 5

[Donal Meehan [:dmeehan]]

Fx133 goes to RC next week, with the final beta building tomorrow.
Though we can take an uplift patch once it's ready and see where it aligns

Comment 6

[Alex Franchuk [:afranchuk]]

There is a simple fix, I will have a patch shortly once verified.

Comment 7

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1931237 - Always use the basename of files stored in the debug_file field r=gsvelto

On Linux, the rust-minidump crates yield (at least in some cases) full
file paths to the debug files. On other platforms this doesn't seem to
be the case. Either way, for all platforms we ensure that the
debug_file field is only the basename.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7624f85e0e84
Always use the basename of files stored in the debug_file field r=gsvelto

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7624f85e0e84

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:afranchuk, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1931237 - Always use the basename of files stored in the debug_file field

On Linux, the rust-minidump crates yield (at least in some cases) full
file paths to the debug files. On other platforms this doesn't seem to
be the case. Either way, for all platforms we ensure that the
debug_file field is only the basename.

Original Revision: https://phabricator.services.mozilla.com/D229015

Comment 12

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Linux user crashes go unnoticed.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: Changes internal details of stack trace information generated by minidump-analyzer. This will only help crash ingestion, which is currently broken by invalid values.
• String changes made/needed: N/A
• Is Android affected?: yes

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/77d260b130a0