Closed Bug 1931368 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 49173 - Change attr type syntax with recent spec changes

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
134 Branch
Tracking Flags:
Tracking Status
firefox134 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 49173 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49173
Details from upstream follow.

Munira Tursunova <moonira@google.com> wrote:

Change attr type syntax with recent spec changes

Recent spec resolution [0] introduced the following changes to attr
type syntax:

  1. Add type() wrapper around \<syntax>
  2. Introduce string keyword for explicitly indicating string parsing
  3. Add dimension units to attach to a \<number>

[0] https://github.com/w3c/csswg-drafts/issues/11035#issuecomment-2474348198

Bug: 369858674, 40320391
Change-Id: I04356918cceaf8445fcdfd896bf3567b2cce792f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020597
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Commit-Queue: Munira Tursunova \<moonira@google.com>
Cr-Commit-Position: refs/heads/main@{#1383003}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 14 tests and 6 subtests

Status Summary

Firefox

OK : 5
PASS: 1[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 55[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]
FAIL: 89

Chrome

OK : 5
PASS: 56
FAIL: 88

Safari

OK : 5
PASS: 56
FAIL: 88

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /css/css-values/attr-color-invalid-cast.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/attr-color-valid.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/attr-in-max.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/attr-in-slotted.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/attr-length-invalid-cast.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/attr-length-valid-zero-nofallback.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/attr-length-valid-zero.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/attr-length-valid.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/attr-IACVT.html [wpt.fyi]
    • CSS Values Test: attr() IACVT: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/attr-all-types.html [wpt.fyi]
    • CSS Values and Units Test: attr: FAIL (Chrome: PASS, Safari: PASS)
    • CSS Values and Units Test: attr 1: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 2: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 3: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 4: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 5: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 6: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 7: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 8: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 9: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 10: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 11: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 12: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 13: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 14: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 15: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 16: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 17: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 18: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 19: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 20: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 21: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 22: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 23: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 24: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 25: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 26: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 27: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 28: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 31: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 33: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 34: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 35: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 36: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 37: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 38: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 39: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 40: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 41: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 42: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 43: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 44: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 45: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 46: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 47: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 48: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 49: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 50: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 51: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 52: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 53: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 54: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 55: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 56: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 57: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 58: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 59: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 60: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 61: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 62: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 63: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 64: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 65: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 66: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 67: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 68: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 69: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 70: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 79: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 80: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 81: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr 82: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/attr-container-style-query.html [wpt.fyi]
    • style query should implement to true: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/attr-invalidation.html [wpt.fyi]
    • CSS Values and Units Test: attr() invalidation: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-values/attr-pseudo-elem-invalidation.html [wpt.fyi]
    • CSS Values and Units Test: attr() invalidation of pseudo elements: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() invalidation of pseudo elements 1: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() invalidation of pseudo elements 2: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() invalidation of pseudo elements 3: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() invalidation of pseudo elements 4: FAIL (Chrome: FAIL, Safari: FAIL)
    • CSS Values and Units Test: attr() invalidation of pseudo elements 5: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a77097b4f3b [wpt PR 49173] - Change attr type syntax with recent spec changes, a=testonly https://hg.mozilla.org/integration/autoland/rev/37220b193d5a [wpt PR 49173] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/0a77097b4f3b
https://hg.mozilla.org/mozilla-central/rev/37220b193d5a

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox134: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
You need to log in before you can comment on or make changes to this bug.