1931478 - Replace mozilla::Clamp with std::clamp in nsGridContainerFrame.cpp

Status: RESOLVED FIXED

(Core :: Layout: Grid, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I'm planning to change RepeatTrackSizingInput::InitFromStyle() to fix bug 1930672, and I found https://phabricator.services.mozilla.com/D227254 is replacing mozilla::Clamp with std::clamp. I can provide a correct fix with an analysis in grid container.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1931478 - Replace mozilla::Clamp with std::clamp in nsGridContainerFrame.cpp. r?#layout

std::clamp() requires min <= max. In
RepeatTrackSizingInput::InitFromStyle(), it computes max as
max = std::max(min, resolved-max-value) in
https://searchfox.org/mozilla-central/rev/4e69784010d271c0fce0927442e4f8e66ffe645b/layout/generic/nsGridContainerFrame.cpp#326-337

Therefore, the max value is never less than min, satisfying min <= max
when calling std::clamp to compute size. Hence, this patch doesn't change
behavior.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6e0a8c205ae
Replace mozilla::Clamp with std::clamp in nsGridContainerFrame.cpp. r=layout-reviewers,emilio

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e6e0a8c205ae

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1931478 - Resolve percentage sizes when computing auto repeat grid tracks.

Comment 5

[Phabricator Automation]

Comment on attachment 9438362 [details]
Bug 1931478 - Resolve percentage sizes when computing auto repeat grid tracks.

Revision D229379 was moved to bug 1930672. Setting attachment 9438362 [details] to obsolete.