Closed Bug 1931499 Opened 10 months ago Closed 10 months ago

Waterfall get high contrast colors even if toolbox theme is not Auto

Categories

(DevTools :: Netmonitor, defect, P3)

defect

Tracking

(firefox134 fixed)

RESOLVED FIXED
134 Branch
Tracking Status
firefox134 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Keywords: no-plan-to-ship)

Attachments

(1 file)

That's because we unconditionally re-set the forced-color-ajust to auto

https://searchfox.org/mozilla-central/rev/b765e2890b0eb85b24f54bc7ff04491fd0704e30/devtools/client/netmonitor/src/assets/styles/RequestList.css#430,438-444

.requests-list-waterfall {
...
  /* Make sure that the background is visible in high Contrast Mode */
  forced-color-adjust: none;
  & > * {
    /* and reset forced-color-adjust on children so we respect HCM */
    forced-color-adjust: auto;
  }
}

we should only do this if HCM support is enabled

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9c80873f25a2 [devtools] Only re-set forced-color-adjust if forced colors is enabled. r=devtools-reviewers,ochameau
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: