1931507 - Toolbox top|side border does not adapt to High Contrast Mode

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

The border is not set in the toolbox document, but in the tab browser one, so we need to indicate to the main browser element that HCM is activated.
We already do such thing for making the browser know about devtools selected theme https://searchfox.org/mozilla-central/rev/b765e2890b0eb85b24f54bc7ff04491fd0704e30/devtools/client/framework/devtools-browser.js#138-151

/**
 * This function makes sure that the "devtoolstheme" attribute is set on the
 * browser window to make it possible to change colors on elements in the
 * browser (like the splitter between the toolbox and web content).
 */
updateDevtoolsThemeAttribute(win) {
  // Set an attribute on root element of each window to make it possible
  // to change colors based on the selected devtools theme.
  let devtoolsTheme = getTheme();
  if (devtoolsTheme != "dark") {
    devtoolsTheme = "light";
  }
  win.document.documentElement.setAttribute("devtoolstheme", devtoolsTheme);
},

we can probably use something similar

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1931507 - [devtools] Adapt toolbox border in High Contrast Mode. r=#devtools.

Make sure the border between the content and the toolbox adapts when the toolbox
is in High Contrast Mode.
This takes inspiration from what we already do to communicate the toolbox theme
to the tab browser element so we can set the right color on the border.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c470f019b19b
[devtools] Adapt toolbox border in High Contrast Mode. r=devtools-reviewers,ochameau.

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c470f019b19b