Closed
Bug 1931707
Opened 8 months ago
Closed 8 months ago
Simplify getListFIle in cZ
Categories
(SeaMonkey :: Chat, task)
SeaMonkey
Chat
Tracking
(seamonkey2.53+ fixed)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
|
1.15 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
At the moment getListFile takes a parameter but none of the callers provide one, so let's remove the parameter and simplify the code.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9438151 -
Flags: review?(frgrahl)
Attachment #9438151 -
Flags: approval-comm-release?
|
||
Updated•8 months ago
|
|
|
||
Comment 2•8 months ago
|
||
Comment on attachment 9438151 [details] [diff] [review]
1931707-irc-getlistfile-25320.patch
LGTM r/a+
Attachment #9438151 -
Flags: review?(frgrahl)
Attachment #9438151 -
Flags: review+
Attachment #9438151 -
Flags: approval-comm-release?
Attachment #9438151 -
Flags: approval-comm-release+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/8db8b957e8d3
Simplify getListFIle in cZ. r=frg a=frg
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
|
|
||
Comment 4•6 months ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/064ed04face3468d25f743151a0b02f5b12867f4
Simplify getListFIle in cZ. r=frg a=frg
You need to log in
before you can comment on or make changes to this bug.
Description
•