1931710 - Use LocalFile directly rather via helper fopen in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

At moment there are a mix of callers to the help fopen and others that just do "new LocalFile" directly.
Let's switch everything to use new LocalFile and remove fopen helper.
Whilst here remove the unused extra arguments for LocalFile.

Comment 1

[Ian Neal]

Attachment: 1931710-irc-file-utils-fopen-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9438154 [details] [diff] [review]
1931710-irc-file-utils-fopen-25320.patch

lgtm r/a+

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7ae5365f6e5d
Use LocalFile directly rather via helper fopen in cZ. r=frg

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/2b81d80799a79bb17b1effefffd427950bf80651
Use LocalFile directly rather via helper fopen in cZ. r=frg a=frg