1931718 - Suggest can return duplicate weather suggestions for the same city

Status: RESOLVED FIXED

(Application Services :: Suggest, defect, P1)

Description

[Drew Willcoxon :adw]

fetch_weather_suggestions() tries to dedupe matching cities, but it doesn't work right because the items it dedupes are (city, region, keyword) tuples, so if two tuples differ only in keyword they won't be deduped, and then later when we discard keywords and convert the tuples to Suggestions, we end up with two suggestions with the same city.

This doesn't cause any visible problems because desktop will only show the first one, but it's unintended and a little wasteful.

You can reproduce this on desktop by searching for "<city> weather", since "weather" matches two different keywords ("weather" and "weather near me").

Comment 1

[BMO Github Automation]

Attachment: [mozilla/application-services] Bug 1931718 - Suggest can return duplicate weather suggestions for the same city (#6477)