Language-specific casing is carried over into object metric data
Categories
(Data Platform and Tools :: Glean: SDK, defect, P1)
Tracking
(Not tracked)
People
(Reporter: afranchuk, Assigned: janerik)
References
Details
The keys of object metric entries use language-specific casing rather than being consistent across languages. This is annoying as a developer, because working on different platforms with the same metrics requires somewhat different code. Besides the client code, it is very cumbersome to deal with this when trying to use ingested data in e.g. BigQuery. For instance, this query merges desktop and Android data: the metrics are identical on both platforms, however the data ends up being incompatible because of the differently named keys.
|
||
Updated•1 year ago
|
|
Assignee | |
Comment 1•2 months ago
|
||
We "accidentally" fixed that in Glean v66.0.0 now.
I'm fixing the crash ping tests in tree.
:afranchuk, where is the data used? I can see if we need to fix up the queries too.
|
|
Assignee | |
Updated•2 months ago
|
|
Reporter | |
Comment 2•2 months ago
|
||
This is the main place it's used. You can see the serde aliases which allow it to read the different keys.
|
|
Assignee | |
Comment 3•2 months ago
|
||
Ah, so it supports both, that's good and will continue to work.
|
|
Assignee | |
Comment 4•2 months ago
|
||
This now landed as part of bug 1991891
Description
•