Closed Bug 1931997 Opened 1 year ago Closed 4 months ago

The graphics for the error pages do not render correctly

Categories

(Firefox for Android :: Browser Engine, defect)

Firefox 134
All
Android
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox132 --- wontfix
firefox133 --- wontfix
firefox134 --- wontfix

People

(Reporter: jonalmeida, Unassigned)

References

Details

(Keywords: regression, regressionwindow-wanted, Whiteboard: [group1][fxdroid])

Attachments

(2 files)

Steps to reproduce

  1. Load any url that leads to an 'Address not found' error.
  2. Observe

Expected behaviour

  • The error page should have a graphics of a smiley face with eyes and a mouth.

Actual behaviour

  • The error page shows the smiley face eyes and the mouth but the rest of it is missing.

Device information

  • Firefox version: All versions from 132 at least from my testing across all browsers (Fenix/Focus/Reference Browser).
  • Android device model: All devices
  • Android OS version: Tested Android 14 and Android 15.

Any additional information?

n/a

Screenshot of the error page graphics unrecognizable on Fenix Nightly 134.

Jon, can you please add a regression window to this bug if/when you get one? Also, can you please add the URL to the bug where you're seeing it?

Flags: needinfo?(jonalmeida942)

I nuked my Fenix Nightly profile on my phone to get it, but I get this regression range from mozregression:

3:27.81 INFO: Narrowed nightly regression window from [2023-04-28, 2023-04-30] (2 days) to [2023-04-28, 2023-04-29] (1 days) (~0 steps left)
3:27.81 INFO: Got as far as we can go bisecting nightlies...
3:27.81 ERROR: Sorry, but mozregression was unable to get a repository - no pushlog url available.
3:27.81 INFO: Newest known good nightly: 2023-04-28
3:27.81 INFO: Oldest known bad nightly: 2023-04-29

https://github.com/mozilla-mobile/firefox-android/commits/main/?since=2023-04-27&until=2023-04-29

GeckoView regression range looks approximately like this:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=381bc623c234&tochange=fa6ba4b8c59f

I forgot to check the exact revs those builds came from so I'm afraid I can't narrow it down much more than that.

Thanks for doing this. I don't think I would have done any better. :)

Flags: needinfo?(jonalmeida942)

I just re-installed Nightly to try to reproduce this and I wasn't able to on my Pixel or S22. I tested in light mode and dark mode as well.

Jon, do you have any other insights on how to get into this state?

Flags: needinfo?(jonalmeida942)

No, I don't. I have tried this on several of our apps with my Pixel 8a and a Samsung A54. It seems to be reproducible for ryanvm too (offline said he has a Pixel 7).

Can you confirm you are seeing the same error page by going to a site that is down (I smash the keyboard and end up with something like eirgnerligbweg.com to reach a non-existent site)?

Flags: needinfo?(jonalmeida942) → needinfo?(jboek)

I was just using foo.bar to test.

Attached video A54 Repro.mp4

I smash the keyboard and end up with something like eirgnerligbweg.com to reach a non-existent site

That's what I did. Here is a recording of a fresh install of Nightly on my A54 (Running Android 12). I see the same behavior on my S22 and Pixel Fold on Android 14 and 13.

Flags: needinfo?(jboek) → needinfo?(jonalmeida942)

Yup, you are seeing the bug reproduced. The smiley should have a face, but you are only seeing the eyes and mouth. Here is the resource SVG: https://searchfox.org/mozilla-central/source/mobile/android/android-components/components/ui/icons/src/main/assets/mozac_error_confused.svg

Flags: needinfo?(jonalmeida942)

Ahah! In your screenshot there was no other content so that was what was concerning to me. Good catch, we'll find out what happened here

The severity field is not set for this bug.
:boek, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(jboek)
Severity: -- → S3
Flags: needinfo?(jboek)
Whiteboard: [group1][fxdroid]

Is anyone still able to repro this? I'm not able to reproduce it. I have tried on my emulator running Android 14, and Samsung S25 running Android 15, and Google Pixel 9 Pro running Android 16

I also had a look at the SVG, and where we generate the HTML page, and it looks...okay to me, don't see anything suspicious.

I wonder if this has to do with the SVG itself, or gecko rendering. My problem right now is that I'm unable to reproduce it

Yeah, this seems to have been fixed starting with 139. I haven't bisected Nightly builds to find the exact fix, however.

Using mozregression --find-fix, I was able to narrow it down to the the 2025-04-03 Nightly build. Pushlog range:
https://hg-edge.mozilla.org/mozilla-central/pushloghtml?fromchange=6be6a06991d7&tochange=e06e468f2d56

Bug 1957689 maybe? Or maybe one of the extension function changes from bug 1958138?

Closing since this is no longer reproducible (probably bug 1957689).

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: