1932001 - [wpt-sync] Sync PR 49247 - Funnel angle value updates in SVGAngle through NewValueSpecifiedUnits

Status: RESOLVED FIXED

(Core :: SVG, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49247 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49247
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Funnel angle value updates in SVGAngle through NewValueSpecifiedUnits

Refactor/structure the code so that all cases[*] that set the
value_in_specified_units_ field does so using NewValueSpecifiedUnits.
This makes it easier to guarantee that the value the orient type enum is
only updated in one place, and that updating it isn't forgotten. Factor
out the conversion from one angle unit to another into a helper, to
facilitate this.

This fixes an issue where the 'valueInSpecifiedUnits' setter didn't
update the orient type.

Export the test svg/dom/SVGMarkerElement-orientType-synchronization.html
to WPT and add an additional case that tests the above.

[*] Code-paths that reset said field when the orient type changes still
(re)set the value themselves.

Fixed: 378120437
Change-Id: I59845590f60d1edbf022a71103d3c6fb3a21aec1
Reviewed-on: https://chromium-review.googlesource.com/6023025
WPT-Export-Revision: e3b40a659a1cc6a3ba6c4f4de7c8df5836f75f21

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=32b039ac3c5b039165507f5e6d95d45b64c15ee0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
PASS: 2

Chrome

OK : 1
PASS: 1
FAIL: 1

Safari

OK : 1
PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19c27654bc2a
[wpt PR 49247] - Funnel angle value updates in SVGAngle through NewValueSpecifiedUnits, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/939c010ba9b8
[wpt PR 49247] - Funnel angle value updates in SVGAngle through NewValueSpecifiedUnits, a=testonly

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/939c010ba9b8