1932118 - `CMD +` (text zoom) not working in dev tools pane with some kdb layout.

Status: NEW

(DevTools :: General, defect, P3)

Description

[pierre pracht]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:132.0) Gecko/20100101 Firefox/132.0

Steps to reproduce:

On Mac OS, French keyboard.
Open Devtools.
Get focus in it.
Hit CMD +
Then try CMD -

Actual results:

CMD + : nothing happened
CMD - : font-size decrease in the panel.

Expected results:

CMD + (CMD shift = on French keyboard) should increase font size.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Negritas Sergiu, Desktop QA]

Hello! Thank you for submitting this issue I have tried to reproduce the issue on my end but unfortunately I wasn't able to with firefox 134.0a1(2024-11-21) on MacOS 15.0
Could you please answer the following questions in order to further investigate this issue?

1. Does this issue happen with a new profile? Here is a link on how to create one: https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles
2. Does this issue happen in the latest nightly? Here is a link from where you can download it: https://www.mozilla.org/en-US/firefox/channel/desktop/
3. Do you have any addons installed? If yes could you please list them?
4. Could you please provide more detailed steps on how to reproduce the issue or provide a screen record with the issue?

Comment 3

[pierre pracht]

Attachment: show the bug on Nightly 21/10/2024

Comment 4

[pierre pracht]

Tested on nightly, zero plugins...
The video shows it clearly :

• CMD + and CMD - work on the HTML page.
• Devtool reacts to CMD - , but CMD + keeps being processed by the HTML page.
• CMD + isn't really "itself" due to the keyboard layout : CMD SHIFT =

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gregtatum, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[Julian Descottes [:jdescottes]]

(In reply to pierre pracht from comment #4)

Tested on nightly, zero plugins...
The video shows it clearly :

• CMD + and CMD - work on the HTML page.
• Devtool reacts to CMD - , but CMD + keeps being processed by the HTML page.
• CMD + isn't really "itself" due to the keyboard layout : CMD SHIFT =

Thanks for the report, we could reproduce the issue. You should actually be able to zoom in if you don't hold "shift", because our keyboard shortcut doesn't expect shift to be pressed when the key is triggered.

We should align to how Firefox handles this and if holding shift produces the expected key, still accept the shortcut.

Comment 7

[Alexandre Poirot [:ochameau]]

The browser code relies on the following logic:
https://searchfox.org/mozilla-central/rev/d6ba5401121104ae242ca18efa6a5672af9cae0f/browser/base/content/browser-sets.inc#296-298
https://searchfox.org/mozilla-central/rev/d6ba5401121104ae242ca18efa6a5672af9cae0f/browser/locales/en-US/browser/browserSets.ftl#177-184

So registering only Accel + "+" and Accel + "=".

Devtools registers the same key shortcuts:
https://searchfox.org/mozilla-central/rev/d6ba5401121104ae242ca18efa6a5672af9cae0f/devtools/client/locales/en-US/toolbox.properties#104-108
So, the shortcuts helpers involved here should ignore the shift if the key character is the expected one.

Comment 8

[Alexandre Poirot [:ochameau]]

We are using KeyShortcuts helper, which includes a workaround for "+":
https://searchfox.org/mozilla-central/rev/d6ba5401121104ae242ca18efa6a5672af9cae0f/devtools/client/shared/key-shortcuts.js#137-141
There is some proper handling of Shift key over there:
https://searchfox.org/mozilla-central/rev/d6ba5401121104ae242ca18efa6a5672af9cae0f/devtools/client/shared/key-shortcuts.js#239-255
But we most likely break it on MacOS over there:
https://searchfox.org/mozilla-central/rev/d6ba5401121104ae242ca18efa6a5672af9cae0f/devtools/client/shared/key-shortcuts.js#250-254

      // OSX: distinguish cmd+[key] from cmd+shift+[key] shortcuts (Bug 1300458)
      const cmdShortcut = shortcut.meta && !shortcut.alt && !shortcut.ctrl;
      if (isAlphabetical || cmdShortcut) {
        return false;
      }

May be bug 1300458 broke that?