Closed Bug 1932196 Opened 1 year ago Closed 1 year ago

[Sections Personalization] scheduled corpus item id change

Categories

(Firefox :: New Tab Page, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
135 Branch
Tracking Status
firefox135 --- fixed

People

(Reporter: thecount, Assigned: thecount)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We need to make a change to one of the ids in the items, this probably involves a new prop with a new item id, and somehow manage the old id.

Assignee: nobody → sdowne

Background: for the Section experiments, we are moving away from a daily schedule. This means that not every content recommendation will have a scheduledItemId. This will have an impact on both the client (new tab) and our analytics (big query, downstream reports).

We propose using corpusItemId as a more stable identifier, as every scheduledItemId already has a corpusItemId backing it. We will begin sending corpusItemId in all responses from Merino. (Jira ticket TBD.) corpusItemId will be of the same data type as scheduledItemId.

On the client, we should use corpusItemId instead of scheduledItemId to handle dismiss functionality. If there are other places where scheduledItemId is used on the client, we should discuss moving to corpusItemId.

For analytics and reporting, we'd like to continue to pass scheduledItemId through as we do currently, though as noted above it will not be a guaranteed field. We should also pass corpusItemId through to analytics.

It may make sense to make this change even outside of the Section experiments, as it would likely be beneficial to begin sending corpusItemId to analytics for all recommendations delivered from Merino.

We would also like to make tileId nullable. Functionally, it's like an integer version of scheduled_corpus_item_id.

Attachment #9439846 - Attachment description: Bug 1932196 - Newtab story id work. → WIP: Bug 1932196 - Newtab story id work.
Attachment #9439846 - Attachment description: WIP: Bug 1932196 - Newtab story id work. → Bug 1932196 - Newtab story id work.
Pushed by sdowne@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ed3f305c58f Newtab story id work. r=home-newtab-reviewers,mconley
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c92619d46c4f Fix lint failure on DiscoveryStreamFeed.sys.mjs . CLOSED TREE
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: