Closed
Bug 1932223
Opened 9 months ago
Closed 9 months ago
Full keywords should not bypass length threshold for Sponsored Suggestion Higher Placement Phase 3
Categories
(Firefox :: Address Bar, defect, P1)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
134 Branch
People
(Reporter: adw, Assigned: adw)
References
Details
(Whiteboard: [sng])
Attachments
(1 file)
Bug 1913507 included a condition in Firefox’s “should show AMP as top pick?” logic that will show a top pick if the full keyword is typed, even if the full keyword length < the threshold length. That was an error I think, due in part to me misunderstanding what “full keyword” means. The full keywords stored in remote settings and returned by the Rust component are not what you would intuitively think of as "full keywords". They usually aren't full phrases and often aren't even full words. We should remove that condition.
|
||
Updated•9 months ago
|
|
Assignee | |
Updated•9 months ago
|
Summary: Full keywords should not trigger top pick for Sponsored Suggestion Higher Placement Phase 3 → Full keywords should not bypass length threshold for Sponsored Suggestion Higher Placement Phase 3
|
|
Assignee | |
Comment 1•9 months ago
|
||
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f81aff297496
Full keywords should not bypass length threshold for Sponsored Suggestion Higher Placement Phase 3. r=daisuke
|
||
Comment 3•9 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•