19323 - View > Enlarge/Reduce Text Size has no effect

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P2)

Description

[jason]

Running Mozilla X11 on Redhat 6.0, glibc2.1, kernel 2.2.13 Went to
http://mrshowbiz.go.com/ Selected 'View ->Enlarge Text Size' menu item. Nothing
happened. Pressed refresh. Still nothing happened. Here is the terminal output:
JavaScript Error: TypeError: window.event has no properties URL:
chrome://navigator/content/navigator.js LineNo: 1066

Comment 1

[Mike McCabe]

There's not much to do with the core JS language here...

The only use of window.event in navigator.js shows up as belonging to law;
reassigning to him, component browser general.

Comment 2

[Robert Ginda]

That line of JS is:

function BrowserReload() {
    dump( "Sorry, command not implemented: " + window.event.srcElement + "\n" );
}

Apparently, the command is not implemented, and the error message isn't showing
because window.event is also not implemented (or broken?)  I'll change this to:

  dump( "Sorry, command not implemented.");

To "fix" the problem, if nobody objects.

Comment 3

[Bill Law]

Fixing the JS so it doesn't generate the error is a fine short-term fix.  But we
need to decide if/how this menu choice is to be implemented and either make it
work correctly or remove the option.

As an aside, there may be a second problem lurking.  "window.event" *should*
always be defined (as best I can determine):  "The event property refers to an
Event object that contains the detals of the most recent event to occur within
window." -- JavaScript, The Defininitive Guide, 3rd Ed., p 718.  So the business
about "window.event has no properties" sounds bogus.

So after we resolve the issue of this menu choice, we should punt this over to
the JS team for consideration of this second issue.

Comment 4

[Robert Ginda]

If you read under the heading titled "Availability" on said page, you will
notice that window.event is only part of Client-side Internet Explorer 4.

window.event was not part of our 4x, and I imagine will *not* be part of
Mozilla, although the DOM/Event Handling folks may have other plans.  The
Netscape way has been for event objects to be passed in as a parameter to the
handler.

I checked in the proposed change, but I suggest the bug stay open until the real
issue (view -> enlarge text size) is implemented or removed.

Comment 5

[Robert Ginda]

*** Bug 20427 has been marked as a duplicate of this bug. ***

Comment 6

[Bill Law]

re: window.event being IE 4 only.

Oops.  I missed that detail; never mind.

Comment 7

[sairuh (rarely reading bugmail)]

updated the summary, since View > Reduce Text Sized doesn't work either. occurs
on all platforms: 1999121508 (mac and linux) and 1999121509 for windows.

Comment 8

[don]

Not required for beta 1.

Comment 9

[don]

Move to M16 for now ...

Comment 10

[Blake Ross]

Isn't this fixed?

Comment 11

[leger]

Putting on [nsbeta2+][5/16] radar.  This is a feature MUST complete work by 
05/16 or we may pull this feature for PR2.

Comment 12

[sairuh (rarely reading bugmail)]

actually, this works now on windows and linux... it's flakey on Mac tho'. i'll
be happy to resolve this feature as fixed (ie, implemented?). but another bug
needs to be opened for the mac...

Comment 13

[sairuh (rarely reading bugmail)]

marking this fixed; gonna file sep bug for mac.

Comment 14

[sairuh (rarely reading bugmail)]

the bug filed for the Mac is bug 39117.

vrfy fixed on winnt and linux using opt comm bits, 2000.07.17.08.