1932347 - Adjust positioning of tab preview for vertical tabs

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P2)

Description

[Sarah Clements [:sclements]]

Attachment: tab preview.png

There's been a request by UX to adjust the positioning for the tab preview so it aligns more precisely with the top of the tabs in both the collapsed and expanded states, per the annotated screenshot.

Comment 1

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1932347 - Adjust vertical tab preview positioning r=#tabbrowser-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f110ffdae936
Adjust vertical tab preview positioning r=tabbrowser-reviewers,dwalker

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f110ffdae936

Comment 4

[Rares Doghi, Desktop QA]

Attachment: p1.png

Hi @Nikki, can you please take a look at these screenshots? I think the Preview for these tabs are a bit higher than they should be, Is this intended ?

Comment 5

[Rares Doghi, Desktop QA]

Attachment: p2.png

This is how they look like in build 20250114045449, is this ok ? @Sarah

Comment 6

[Sarah Clements [:sclements]]

Yeah, it does look a little too high from the initial screenshot included in the description.

Comment 7

[Nikki Sharpley (:nikkis) (she/her)]

Interesting. It was in line locally. I'll take a look! Thanks!

Comment 8

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1932347 - Adjust positioning of tab preview for vertical tabs r=#sidebar-reviewers

Previous patch was slightly off in Nightly. Opt for 3px offset instead.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/933bfbddaf61
Adjust positioning of tab preview for vertical tabs r=tabbrowser-reviewers,dwalker

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/933bfbddaf61