Closed Bug 1932575 Opened 1 year ago Closed 1 year ago

Cannot acces Saved password - fingerprint unavailable even when is set

Categories

(Firefox for Android :: Logins, defect)

Firefox 134
All
Android
defect

Tracking

()

VERIFIED FIXED
134 Branch
Tracking Status
firefox132 --- unaffected
firefox133 + verified
firefox134 + verified

People

(Reporter: mlobontiuroman, Assigned: avirvara)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Attached file logcatPasswords.txt

Steps to reproduce

  1. Make sure you are signed in and have at least one password saved.
  2. Make sure to have fingerprint/pattern enabled on the device.
  3. Go to Settings - General - Passwords - Saved passwords.
  4. When asked to unlock to view your saved passwords, enter the valid fingerprint/pattern.

Expected behavior

After step 4, the user can view the saved passwords.

Actual behavior

After step 4, the "Unlock..." prompt is displayed again, and again, even though the pattern is correct.
On some devices, the fingerprint is unavailable event though it is set.
After letting the app to "rest" a few seconds (4-5 seconds), the "Unlock..." prompt is dismissed, and I have access to the passwords.

Device information

  • Firefox version: 133.0, Nightly 134.0a1 from 11/20
  • Android devices: Xiaomi Mi8 Lite (Android 10), Samsung Galaxy Note 8 (Android 9)

Attaching a short video, for better understanding the issue.

avirvara/:boek is this a possible regression from Bug 1928779?
Tracking if this can be investigated for a dot release fix

Flags: needinfo?(jboek)
Flags: needinfo?(avirvara)
Assignee: nobody → avirvara
Flags: needinfo?(avirvara)

Setting Bug 1928779 as the regressor, please correct later as needed

Keywords: regression
Regressed by: CVE-2024-11703
Attachment #9439207 - Attachment description: WIP: Bug 1932575: allow users to access saved logins via biometric authentication → Bug 1932575: allow users to access saved logins via biometric authentication
Pushed by avirvara@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b745003e2c45 allow users to access saved logins via biometric authentication r=boek,android-reviewers
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
Flags: needinfo?(jboek)

Verified as fixed on the latest Fenix Nightly 134.0a1 from 11/25, with Xiaomi Mi8 Lite (Android 10), Samsung Galaxy Note 8 (Android 9).

Alexandra, please add a release uplift request on this. We can aim to take it in the planned Android dot release.

Flags: needinfo?(avirvara)

Comment on attachment 9439021 [details]
logcatPasswords.txt

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: some users won't be able to authenticate using biometric authentication even if it's set
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Medium
  • Why is the change risky/not risky? (and alternatives if risky): we observed that biometric auth implementation may differ from one Android version to another. we covered all the known cases, but it may happen that we haven't covered all of them.
  • String changes made/needed:
  • Is Android affected?: Yes
Flags: needinfo?(avirvara)
Attachment #9439021 - Flags: approval-mozilla-beta?

Comment on attachment 9439207 [details]
Bug 1932575: allow users to access saved logins via biometric authentication

Changing uplift request from beta to release and moving to the patch attachment.

Attachment #9439207 - Flags: approval-mozilla-release?
Attachment #9439021 - Flags: approval-mozilla-beta?

Comment on attachment 9439207 [details]
Bug 1932575: allow users to access saved logins via biometric authentication

Approved for Android 133.0.1

Attachment #9439207 - Flags: approval-mozilla-release? → approval-mozilla-release+
Flags: qe-verify+

Verified on the 133.0.1 Firefox for Android with the following devices:

  • Pixel 9 Pro XL (Android 15),
  • Redmi Pad SE (Android 12),
  • Motorola Nexus 6 (Android 8),
  • Sony Xperia Z5 Premium (Android 7.1.1),
  • Google Pixel 6 (Android 15),
  • Oppo Find X3 Lite (Android 11), and
  • Xiaomi Mi8 Lite (Android 10).
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Duplicate of this bug: 1929856
See Also: → 1952870
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: