1932642 - Enable devtools.high-contrast-mode-support on Nightly

Status: RESOLVED FIXED

(DevTools :: General, task)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Nathan, how would you feel about it?
My idea is that it would be great to have more eyes on this so we could get report about issues I didn't catch

Comment 2

[Nathan LaPré]

I 100% support this. Community feedback would be excellent, and the Dev Tools in HCM are so nice to use now that I think it's almost doing a disservice to Firefox users to not let them have it by default. I just tested it out again to make sure there aren't any glaring issues, and I didn't find any.

I suppose if we really wanted to mitigate risk, we could have some more-visible way to inform people about how to turn off devtools.high-contrast-mode-support? A little info message on first load, or a blog post, or something like that.

If we get some time, me or someone else from the a11y team could also go over things more carefully and identify any remaining issues. Maybe it could be an "engineering review" on DevTools HCM as a whole. I think we can do that in tandem with community feedback.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Nathan LaPré from comment #2)

I 100% support this. Community feedback would be excellent, and the Dev Tools in HCM are so nice to use now that I think it's almost doing a disservice to Firefox users to not let them have it by default. I just tested it out again to make sure there aren't any glaring issues, and I didn't find any.

Perfect

I suppose if we really wanted to mitigate risk, we could have some more-visible way to inform people about how to turn off devtools.high-contrast-mode-support? A little info message on first load, or a blog post, or something like that.

I'll think of something. At the moment we only enable HCM if you have the "Auto" theme selected in DevTools settings. We could have a (High Contrast) label next to the option in the settings. And on top of that we could have a notification when:

• someone has HCM enabled but has either light or dark option selected, have a notification to indicate them they can have a High Contrast mode for their DevTools
• someone has HCM enabled with Auto option selected, have a notification to indicate that they can turn off High Contrast Mode by selecting one of the light/dark theme

I'll file bugs for this

If we get some time, me or someone else from the a11y team could also go over things more carefully and identify any remaining issues. Maybe it could be an "engineering review" on DevTools HCM as a whole. I think we can do that in tandem with community feedback.

That would be great because I did review the toolbox in HCM alone and try to file things that were clearly wrong, but there might be issues I'm not aware of that still needs to be fixed. Is there a process we need to kick off to have such engineering review ?

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #3)

I suppose if we really wanted to mitigate risk, we could have some more-visible way to inform people about how to turn off devtools.high-contrast-mode-support? A little info message on first load, or a blog post, or something like that.

I'll think of something. At the moment we only enable HCM if you have the "Auto" theme selected in DevTools settings. We could have a (High Contrast) label next to the option in the settings. And on top of that we could have a notification when:

• someone has HCM enabled but has either light or dark option selected, have a notification to indicate them they can have a High Contrast mode for their DevTools
• someone has HCM enabled with Auto option selected, have a notification to indicate that they can turn off High Contrast Mode by selecting one of the light/dark theme

I'll file bugs for this

Here it is Bug 1932820

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1932642 - [devtools] Enable devtools.high-contrast-mode-support on Nightly. r=#devtools.

Comment 6

[Nathan LaPré]

I'll file bugs for this

Thanks for doing that, those are great ideas.

Is there a process we need to kick off to have such engineering review ?

Here's the guide for it, but essentially you just set the a11y-review flag to REQUESTED on a relevant bug (could be this bug, could be a dedicated review bug). I think this is good to do, at least just for a11y team tracking, even if it's a bit formal. Ultimately the result will be the same: someone (probably me) will take some time to look it over and file bugs if we find any.

There are 20-ish bugs still blocking Bug 1590215. What's your plan for those? For an engineering review, I guess we'd avoid re-filing bugs that are already covered by that list.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ec9a9365f14
[devtools] Enable devtools.high-contrast-mode-support on Nightly. r=devtools-reviewers,ochameau.

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/9ec9a9365f14

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Nathan LaPré from comment #6)

Is there a process we need to kick off to have such engineering review ?

Here's the guide for it, but essentially you just set the a11y-review flag to REQUESTED on a relevant bug (could be this bug, could be a dedicated review bug). I think this is good to do, at least just for a11y team tracking, even if it's a bit formal. Ultimately the result will be the same: someone (probably me) will take some time to look it over and file bugs if we find any.

Okay great. I filed Bug 1933376 to enable the pref by default, so I'll set the a11-review flag on it once I'm done with the things on my todo list

There are 20-ish bugs still blocking Bug 1590215. What's your plan for those? For an engineering review, I guess we'd avoid re-filing bugs that are already covered by that list.

My plan is to fix all the a11y-s2 before the end of the year (~12 bugs left)

Comment 10

[Nathan LaPré]

Sounds good, thank you!

Comment 11

[Donal Meehan [:dmeehan]]

:nchevobbe could you consider nominating this for a release note? (Process info)
We could include it in the nightly only release notes.

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

[Tracking Requested - why for this release]:
(This is Nightly only)

When in High Contrast Mode, the DevTools toolbox colors are updated to have higher contrast than the regular theme. This only works when a few conditions are met:

• High Contrast Mode is set at the OS level (see https://support.microsoft.com/en-us/windows/change-color-contrast-in-windows-fedc744c-90ac-69df-aed5-c8a90125e696).
• In about:settings, in the Colors popup, Use system colors is checked, and Override the colors specified by the page with your selections above is set to something else than Never
• In DevTools settings, the selected Theme is Auto

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Added to the Nightly relnotes.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Removing from the Nightly release notes per our policy of keeping them there for a maximum of 3 cycles. We can add a new note for bug 1933376 once that lands and is ready to ride the trains.