193265 - accesskeys missing from linked dialogs to Preference main dialog.

Status: NEW

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Jessie Li]

Comment 1

[Kyle Yuan]

to Jessie

Comment 2

[Jessie Li]

accesskeys for the following widgets:

Navigator/Languages->Add Languages: Others text area;
Privacy & Security/Cookies->Manage Stored Cookies: 4 Remove buttons;
Privacy & Security/Images->Manage Image Permissions: 2 Remove buttons;
Privacy & Security/Forms->Manage Sites: 4 Remove buttons;
Privacy & Security/Passwords->Manage Stored Passwords: 4 Remove buttons;
Privacy & Security/Master Passwords->Change Password dialog.
Privacy & Security/Certificates->Certificate Manager dialog,Device Manager dialog;
Privacy & Security/Validation->Manage CRLs dialog;

Form manager is another bug 193271

Comment 3

[Jessie Li]

taking...

Comment 4

[Jessie Li]

add accesskey to following:
Mail->Addressing->Edit Directories->Add: 3 tabs;
Privacy & Security/Cookies->Manage Stored Cookies: 4 Remove buttons;2 tabs;
Privacy & Security/Forms->Manage Sites: 4 Remove buttons;
Privacy & Security/Passwords->Manage Stored Passwords: 4 Remove buttons;
Privacy & Security/Master Passwords->Change Password dialog.
Privacy & Security/Certificates->Certificate Manager dialog,Device Manager dialog;
Privacy & Security/Validation->Manage CRLs dialog;

Comment 5

[Jessie Li]

Attachment: patch

Comment 6

[Jessie Li]

Comment on attachment 115368 [details] [diff] [review]
patch

Hi timeless, please help me to review this bug. It is the similar with the last
bug you reviewed for me. Thanks!

Comment 7

[piers]

Jessie, had a quick look at your patch:

 <!ENTITY advancedOptionsButton.label       "Advanced Options">
 <!ENTITY advancedOptionsButton.accesskey   "a">
Do you want to take this oppotunity to capatalise keys? (you dont have to of 
course:)

 <!ENTITY     removepermission.label         "Remove Site">
+<!ENTITY     removepermission.accesskey     "R">
 <!ENTITY     removeallpermissions.label     "Remove All Sites">
+<!ENTITY     removeallpermissions.accesskey "e">
 <!ENTITY     removeimage.label              "Remove Site">
+<!ENTITY     removeimage.accesskey          "R">
 <!ENTITY     removeallimages.label          "Remove All Sites">
+<!ENTITY     removeallimages.accesskey      "e">

These won't work! Due to bug 143065, accesskeys have scope over the whole dialog
not just the tab panel.

/cvsroot/mozilla/extensions/wallet/signonviewer/SignonViewer.dtd

For the same reason you can't use the same accesskey for "Remove All" accross
tabs.

(I'm sure there's more of these instances where this is a problem in your patch
because you're working on a lot of dialogs with tabs)

 <!ENTITY devmgr.button.logout.label "Log Out">
+<!ENTITY devmgr.button.logout.accesskey "o">

Use "O" instead so its Log _O_ut instead of L_o_g Out


Also, are you sure you want to add accesskeys to tabs? I thought using Ctrl+Tab
was Ok for tab switching. (Windows doesn't have accesskeys on tabs for native
applications, i'm not sure about other platforms)

Hope this helps.

Comment 8

[piers]

Looked a little further at the tab panel labels accesskey thing:

* Windows doesn't use them;
* MacOS X doesn't seem to use accesskeys at all (is this true?!);
* KDE does use them;
* GNOME doesn't use them.

This is what the GNOME Human Interface Guidelines has to say:

"Do not assign access keys to tab labels, as this means you cannot use those 
access keys for any control on any of the tabs. Assign an access key to every
other control on each page, however."

Obviously we aren't GNOME, but i agree with what they say on the subject.

Aaron, what do you think on this?

Comment 9

[timeless]

Comment on attachment 115368 [details] [diff] [review]
patch

address piers's comments.

note that mozilla policy for the time being is not to place access keys on
tabs. at some future point we might change this since it could be theoretically
possible to allow themes to decide whether to show access keys (and therefor
allow a KDE theme to show them) however we don't do have the code to do that at
this time.

Comment 10

[Jessie Li]

Piers and timeless, I am sorry I missed mozilla's policy about no accesskeys on
tabs. I want to do this because I found in Page Info dialog, there tabs have
accesskeys. You can open Page Info by clicking View->Page Info.

BTW, could you point me where can I find more rules for accesskeys, such as
this, no accesskeys on tabs? I want to learn more about it so that I can't miss
anything. 

Thanks for your efforts.

Comment 11

[Jessie Li]

I will make another patch removing accesskeys on tabs.

Piers, I added you in the CC list of the bug 143065. Because this bug is closly
related with that bug. What do you think about bug 143065? I think it should be
fixed from the point of the users view. 

Comment 12

[piers]

Jessie, i don't think Mozilla does have a policy on accesskeys on tab panels at 
the moment, but for the reasons given in comment 8, i don't think we should add 
them (Aaron would be the person to have the final say i think).

Any current policies are at:
http://www.mozilla.org/projects/ui/accessibility/accesskey.html

We should add something about tab panels to there.

I think that the biggest blockers to any work on accesskeys at the moment  are 
bug 143065 and bug 68841, but unfortunately no-one has touched them in a while :(

Thanks for your work on these patches. :)

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.