1932676 - The Profiles right-arrow icon is misaligned in the Hamburger menu

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect, P2)

Description

[Simona Badau, Desktop QA]

Attachment: Screenshot with the issue

Found in

• Nightly 134.0a1

Affected versions

• Nightly 134.0a1

Tested platforms

• Affected platforms: Windows 11, macoS 15

Preconditions

• Use a new profile created via the profile manager.
• Ensure that the pref "browser.profiles.enabled" is set to true in about:config.

Steps to reproduce

1. Click on the Hamburger menu.
2. Observe the Profiles option in the menu.

Expected result

• The Profiles menu option should display a right-arrow icon at the end of the row.

Actual result

• The first time the Hamburger menu is opened after launching Firefox, the right-arrow icon appears on the left side of the panel instead of the far right. This issue only occurs when no additional profiles have been created and only during the first menu opening after launching Firefox.
  Please see the attached screenshot for more details.

Regression range

• This is not a regression.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mossop, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Mass setting S2 severity for 0.5% release bugs. Apologies for the bug spam!

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: Account_menu_screenshot.png

The Account menu's Profile menu item's > arrow is also misaligned.

The hamburger menu's Profile menu item's > arrow is only misaligned the first time I open the menu. It moves to the correct alignment the second time I open it. The Account menu's arrow doesn't move when reopening the menu.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

This is not a layout issue. When you first open the menu, the markup is:

<toolbarbutton id="appMenu-empty-profiles-button" class="subviewbutton subviewbutton-nav" closemenu="none" data-l10n-id="appmenu-profiles">Profiles</toolbarbutton>

When you reopen it it is:

<toolbarbutton id="appMenu-empty-profiles-button" class="subviewbutton subviewbutton-nav" closemenu="none" data-l10n-id="appmenu-profiles">Profiles<image class="toolbarbutton-icon"/><label class="toolbarbutton-text" crop="end" flex="1"/></toolbarbutton>

It seems how the toolbarbutton is created is probably wrong. Does that help?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1932676 - Fix localization of profiles button. r=mossop,jhirsch

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7abfb8a79b32
Fix localization of profiles button. r=mossop,fluent-reviewers,bolsson

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7abfb8a79b32

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox136 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Dave Townsend [:mossop]]

This feature is disabled in 136.